Greg,
On Wed, 2014-05-28 at 11:42 -0700, Greg Kroah-Hartman wrote:
> On Wed, May 28, 2014 at 07:59:08PM +0200, Paul Bolle wrote:
> > On Wed, 2014-05-28 at 19:55 +0200, Alexandre Belloni wrote:
> > > On 28/05/2014 at 18:09:43 +0200, Paul Bolle wrote :
> > > > On Wed, 2014-05-28 at 17:59 +0200, Alexandre Belloni wrote:
> > > > > On 28/05/2014 at 14:24:27 +0200, Paul Bolle wrote :
> > > > > > > > config ATMEL_PWM
> > > > > > > > tristate "Atmel AT32/AT91 PWM support"
> > > > > > > > - depends on HAVE_CLK && (AVR32 || ARCH_AT91 || COMPILE_TEST)
> > > > > > > > + depends on HAVE_CLK
> > > > > > > > + depends on AVR32 || AT91SAM9263 || AT91SAM9RL || AT91SAM9G45
> > > > > >
> > > > > > Symbols AT91SAM9263, AT91SAM9RL, and AT91SAM9G45 do not seem to exist in
> > > > > > next-20140528. Should these perhaps be SOC_AT91SAM9263, SOC_AT91SAM9RL,
> > > > > > and SOC_AT91SAM9G45 and/or ARCH_AT91SAM9263, ARCH_AT91SAM9RL, and
> > > > > > ARCH_AT91SAM9G45?
> > > > >
> > > > > I wouldn't bother too much fixing that, this will definitely be remove
> > > > > in 3.17.
> > > >
> > > > Are you talking about: 1) the problem this patch tried to fix; or 2) the
> > > > problem it created?
> > > >
> > >
> > > I'm removing the whole atmel_pwm driver so the CONFIG_ATMEL_PWM symbol
> > > will be gone.
> >
> > So the patch we're discussing here will never be included in a release?
>
> So, should I just remove it right now? I like deleting files :)
This has landed unchanged in v3.16-rc1. Should I submit the trivial
patch to remove these pointless references to the unknown symbols
AT91SAM9263, AT91SAM9RL, and AT91SAM9G45?
Thanks,
Paul Bolle
Hi,
On 18/06/2014 at 11:19:30 +0200, Paul Bolle wrote :
> This has landed unchanged in v3.16-rc1. Should I submit the trivial
> patch to remove these pointless references to the unknown symbols
> AT91SAM9263, AT91SAM9RL, and AT91SAM9G45?
>
Because of dependencies, the pull request was delayed until after
3.16-rc1. It has been resent and this should be solved for 3.16-rc2:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-June/264181.html
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
AT91 symbols AT91SAM9263, AT91SAM9RL, and AT91SAM9G45 do not exist and this
patch change them their correct ARCH_* version.
These symbols are chosen instead of the SOC_* one because this driver is not
converted to DT.
Anyway, the ATMEL_PWM symbol and the associated driver will be removed soon
during the move to the PWM sub-system.
Reported-by: Paul Bolle <[email protected]>
Signed-off-by: Nicolas Ferre <[email protected]>
---
Guys,
The rework is delayed to 3.17. So, in the meantime, I send this little patch
as a fix for 3.16.
Bye,
drivers/misc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index a43d0c467274..ee9402324a23 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -54,7 +54,7 @@ config AD525X_DPOT_SPI
config ATMEL_PWM
tristate "Atmel AT32/AT91 PWM support"
depends on HAVE_CLK
- depends on AVR32 || AT91SAM9263 || AT91SAM9RL || AT91SAM9G45
+ depends on AVR32 || ARCH_AT91SAM9263 || ARCH_AT91SAM9RL || ARCH_AT91SAM9G45
help
This option enables device driver support for the PWM channels
on certain Atmel processors. Pulse Width Modulation is used for
--
1.8.2.2
On 25/06/2014 at 11:43:56 +0200, Nicolas Ferre wrote :
> AT91 symbols AT91SAM9263, AT91SAM9RL, and AT91SAM9G45 do not exist and this
> patch change them their correct ARCH_* version.
> These symbols are chosen instead of the SOC_* one because this driver is not
> converted to DT.
> Anyway, the ATMEL_PWM symbol and the associated driver will be removed soon
> during the move to the PWM sub-system.
>
> Reported-by: Paul Bolle <[email protected]>
> Signed-off-by: Nicolas Ferre <[email protected]>
Acked-by: Alexandre Belloni <[email protected]>
> ---
> Guys,
>
> The rework is delayed to 3.17. So, in the meantime, I send this little patch
> as a fix for 3.16.
>
> Bye,
>
> drivers/misc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index a43d0c467274..ee9402324a23 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -54,7 +54,7 @@ config AD525X_DPOT_SPI
> config ATMEL_PWM
> tristate "Atmel AT32/AT91 PWM support"
> depends on HAVE_CLK
> - depends on AVR32 || AT91SAM9263 || AT91SAM9RL || AT91SAM9G45
> + depends on AVR32 || ARCH_AT91SAM9263 || ARCH_AT91SAM9RL || ARCH_AT91SAM9G45
> help
> This option enables device driver support for the PWM channels
> on certain Atmel processors. Pulse Width Modulation is used for
> --
> 1.8.2.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com