2014-06-26 11:25:39

by Rickard Strandqvist

Subject: [PATCH] pinctrl: pinctrl-at91.c: Cleaning up if unsigned is less than zero

Remove checking if a unsigned is less than zero

This was found using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <[email protected]>
---
drivers/pinctrl/pinctrl-at91.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index 421493c..17ef8b3 100644
--- a/drivers/pinctrl/pinctrl-at91.c
+++ b/drivers/pinctrl/pinctrl-at91.c
@@ -945,7 +945,7 @@ static int at91_pinctrl_parse_functions(struct device_node *np,
/* Initialise function */
func->name = np->name;
func->ngroups = of_get_child_count(np);
- if (func->ngroups <= 0) {
+ if (func->ngroups == 0) {
dev_err(info->dev, "no groups defined\n");
return -EINVAL;
}
--
1.7.10.4

2014-07-07 15:36:44

by Linus Walleij

Subject: Re: [PATCH] pinctrl: pinctrl-at91.c: Cleaning up if unsigned is less than zero

On Thu, Jun 26, 2014 at 1:26 PM, Rickard Strandqvist
<[email protected]> wrote:

> Remove checking if a unsigned is less than zero
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <[email protected]>

Patch applied. Thanks!

Yours,
Linus Walleij