2014-06-26 13:37:21

by Rickard Strandqvist

Subject: [PATCH] gpio: gpio-vr41xx.c: Cleaning up values that are never used

Remove variable that are never used

This was found using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <[email protected]>
---
drivers/gpio/gpio-vr41xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-vr41xx.c b/drivers/gpio/gpio-vr41xx.c
index 66cbcc1..ce0bb24 100644
--- a/drivers/gpio/gpio-vr41xx.c
+++ b/drivers/gpio/gpio-vr41xx.c
@@ -515,7 +515,7 @@ static int giu_probe(struct platform_device *pdev)
struct resource *res;
unsigned int trigger, i, pin;
struct irq_chip *chip;
- int irq, retval;
+ int irq;

switch (pdev->id) {
case GPIO_50PINS_PULLUPDOWN:
@@ -544,7 +544,7 @@ static int giu_probe(struct platform_device *pdev)

vr41xx_gpio_chip.dev = &pdev->dev;

- retval = gpiochip_add(&vr41xx_gpio_chip);
+ gpiochip_add(&vr41xx_gpio_chip);

giu_write(GIUINTENL, 0);
giu_write(GIUINTENH, 0);
--
1.7.10.4

2014-07-08 07:25:01

by Linus Walleij

Subject: Re: [PATCH] gpio: gpio-vr41xx.c: Cleaning up values that are never used

On Thu, Jun 26, 2014 at 3:38 PM, Rickard Strandqvist
<[email protected]> wrote:

> Remove variable that are never used
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <[email protected]>

Hm that was easy enough to fix up properly by actually checking
the return value so I cooked another patch and put you as
Reported-by:, should be on the linux-gpio list.

Yours,
Linus Walleij