2014-06-26 16:16:15

by Rickard Strandqvist

Subject: [PATCH] gpio: gpio-twl4030.c: Cleaning up null pointer checks that could never happen

Removal of null pointer checks that could never happen

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <[email protected]>
---
drivers/gpio/gpio-twl4030.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-twl4030.c b/drivers/gpio/gpio-twl4030.c
index 3ebb1a5..826da37 100644
--- a/drivers/gpio/gpio-twl4030.c
+++ b/drivers/gpio/gpio-twl4030.c
@@ -554,7 +554,7 @@ no_irqs:

platform_set_drvdata(pdev, priv);

- if (pdata && pdata->setup) {
+ if (pdata->setup) {
int status;

status = pdata->setup(&pdev->dev, priv->gpio_chip.base,
--
1.7.10.4

2014-07-08 07:27:15

by Linus Walleij

Subject: Re: [PATCH] gpio: gpio-twl4030.c: Cleaning up null pointer checks that could never happen

On Thu, Jun 26, 2014 at 6:17 PM, Rickard Strandqvist
<[email protected]> wrote:

> Removal of null pointer checks that could never happen
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <[email protected]>

That's correct. Patch applied!

Yours,
Linus Walleij