2014-06-26 16:17:46

by Rickard Strandqvist

Subject: [PATCH] gpio: gpio-ucb1400.c: Cleaning up null pointer checks that could never happen

Removal of null pointer checks that could never happen

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <[email protected]>
---
drivers/gpio/gpio-ucb1400.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-ucb1400.c b/drivers/gpio/gpio-ucb1400.c
index 2445fe7..d520dc9 100644
--- a/drivers/gpio/gpio-ucb1400.c
+++ b/drivers/gpio/gpio-ucb1400.c
@@ -70,7 +70,7 @@ static int ucb1400_gpio_probe(struct platform_device *dev)
if (err)
goto err;

- if (ucb && ucb->gpio_setup)
+ if (ucb->gpio_setup)
err = ucb->gpio_setup(&dev->dev, ucb->gc.ngpio);

err:
--
1.7.10.4

2014-07-08 07:29:14

by Linus Walleij

Subject: Re: [PATCH] gpio: gpio-ucb1400.c: Cleaning up null pointer checks that could never happen

On Thu, Jun 26, 2014 at 6:18 PM, Rickard Strandqvist
<[email protected]> wrote:

> Removal of null pointer checks that could never happen
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <[email protected]>

Correct, patch applied.

Yours,
Linus Walleij