2014-06-26 16:57:42

by Rickard Strandqvist

Subject: [PATCH] pinctrl: pinctrl-single.c: Cleaning up wrong format string usage

%d in format string used, but the type is unsigned int

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <[email protected]>
---
drivers/pinctrl/pinctrl-single.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index 2960557..a0a8bdf 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -836,7 +836,7 @@ static int pcs_add_pin(struct pcs_device *pcs, unsigned offset,

pin = &pcs->pins.pa[i];
pn = &pcs->names[i];
- sprintf(pn->name, "%lx.%d",
+ sprintf(pn->name, "%lx.%u",
(unsigned long)pcs->res->start + offset, pin_pos);
pin->name = pn->name;
pin->number = i;
--
1.7.10.4

2014-07-07 15:53:01

by Linus Walleij

Subject: Re: [PATCH] pinctrl: pinctrl-single.c: Cleaning up wrong format string usage

On Thu, Jun 26, 2014 at 6:58 PM, Rickard Strandqvist
<[email protected]> wrote:

> %d in format string used, but the type is unsigned int
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <[email protected]>

Patch applied.

Yours,
Linus Walleij