2014-06-28 21:33:29

by Rickard Strandqvist

Subject: [PATCH] mfd: ab8500-debugfs.c: Cleaning up unnecessary to test, unsigned can't be negative.

Unsigned variable can't be negative so it is unnecessary to test it

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <[email protected]>
---
drivers/mfd/ab8500-debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
index d1a22aa..0793a10 100644
--- a/drivers/mfd/ab8500-debugfs.c
+++ b/drivers/mfd/ab8500-debugfs.c
@@ -2504,7 +2504,7 @@ static ssize_t ab8500_gpadc_trig_timer_write(struct file *file,
if (err)
return err;

- if ((user_trig_timer >= 0) && (user_trig_timer <= 255)) {
+ if (user_trig_timer <= 255) {
trig_timer = (u8) user_trig_timer;
} else {
dev_err(dev, "debugfs error input: "
--
1.7.10.4

2014-07-02 06:54:38

by Lee Jones

Subject: Re: [PATCH] mfd: ab8500-debugfs.c: Cleaning up unnecessary to test, unsigned can't be negative.

> Unsigned variable can't be negative so it is unnecessary to test it
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <[email protected]>
> ---
> drivers/mfd/ab8500-debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
> index d1a22aa..0793a10 100644
> --- a/drivers/mfd/ab8500-debugfs.c
> +++ b/drivers/mfd/ab8500-debugfs.c
> @@ -2504,7 +2504,7 @@ static ssize_t ab8500_gpadc_trig_timer_write(struct file *file,
> if (err)
> return err;
>
> - if ((user_trig_timer >= 0) && (user_trig_timer <= 255)) {
> + if (user_trig_timer <= 255) {
> trig_timer = (u8) user_trig_timer;
> } else {
> dev_err(dev, "debugfs error input: "

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog