2014-07-02 21:56:02

by Rickard Strandqvist

Subject: [PATCH] video: fbdev: sh_mipi_dsi.c: Cleaning up Boolean used in bitwise operation

Boolean variable is used in bitwise operation.
I personally find that this was pretty ugly, but think a solution like this yet is more correct.

This was found using a static code analysis program called cppcheck

Rickard Strandqvist (1):
video: fbdev: sh_mipi_dsi.c: Cleaning up Boolean used in bitwise operation

drivers/video/fbdev/sh_mipi_dsi.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

--
1.7.10.4

2014-07-02 21:56:16

by Rickard Strandqvist

Subject: [PATCH] video: fbdev: sh_mipi_dsi.c: Cleaning up Boolean used in bitwise operation

Boolean variable is used in bitwise operation.

Signed-off-by: Rickard Strandqvist <[email protected]>
---
drivers/video/fbdev/sh_mipi_dsi.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/sh_mipi_dsi.c b/drivers/video/fbdev/sh_mipi_dsi.c
index 8f6e8ff..39417ab 100644
--- a/drivers/video/fbdev/sh_mipi_dsi.c
+++ b/drivers/video/fbdev/sh_mipi_dsi.c
@@ -113,11 +113,18 @@ static int sh_mipi_dcs_param(int handle, u8 cmd, u8 param)

static void sh_mipi_dsi_enable(struct sh_mipi *mipi, bool enable)
{
+ unsigned int enable_value;
+
+ if (enable)
+ enable_value = 0x00000003;
+ else
+ enable_value = 0x00000002;
+
/*
* enable LCDC data tx, transition to LPS after completion of each HS
* packet
*/
- iowrite32(0x00000002 | enable, mipi->linkbase + DTCTR);
+ iowrite32(enable_value, mipi->linkbase + DTCTR);
}

static void sh_mipi_shutdown(struct platform_device *pdev)
--
1.7.10.4