2014-07-04 19:37:16

by Fabian Frédérick

Subject: [PATCH 1/1] drm/radeon: remove null test before kfree

Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required

Cc: Alex Deucher <[email protected]>
Cc: David Airlie <[email protected]>
Cc: [email protected]
Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/gpu/drm/radeon/radeon_pm.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c
index e447e39..a06afee 100644
--- a/drivers/gpu/drm/radeon/radeon_pm.c
+++ b/drivers/gpu/drm/radeon/radeon_pm.c
@@ -1400,9 +1400,7 @@ static void radeon_pm_fini_old(struct radeon_device *rdev)
}

radeon_hwmon_fini(rdev);
-
- if (rdev->pm.power_state)
- kfree(rdev->pm.power_state);
+ kfree(rdev->pm.power_state);
}

static void radeon_pm_fini_dpm(struct radeon_device *rdev)
@@ -1421,9 +1419,7 @@ static void radeon_pm_fini_dpm(struct radeon_device *rdev)
radeon_dpm_fini(rdev);

radeon_hwmon_fini(rdev);
-
- if (rdev->pm.power_state)
- kfree(rdev->pm.power_state);
+ kfree(rdev->pm.power_state);
}

void radeon_pm_fini(struct radeon_device *rdev)
--
1.9.1

2014-07-07 20:42:55

by Alex Deucher

Subject: Re: [PATCH 1/1] drm/radeon: remove null test before kfree

On Fri, Jul 4, 2014 at 3:37 PM, Fabian Frederick <[email protected]> wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
>
> Cc: Alex Deucher <[email protected]>
> Cc: David Airlie <[email protected]>
> Cc: [email protected]
> Signed-off-by: Fabian Frederick <[email protected]>

Applied. thanks!

Alex

> ---
> drivers/gpu/drm/radeon/radeon_pm.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c
> index e447e39..a06afee 100644
> --- a/drivers/gpu/drm/radeon/radeon_pm.c
> +++ b/drivers/gpu/drm/radeon/radeon_pm.c
> @@ -1400,9 +1400,7 @@ static void radeon_pm_fini_old(struct radeon_device *rdev)
> }
>
> radeon_hwmon_fini(rdev);
> -
> - if (rdev->pm.power_state)
> - kfree(rdev->pm.power_state);
> + kfree(rdev->pm.power_state);
> }
>
> static void radeon_pm_fini_dpm(struct radeon_device *rdev)
> @@ -1421,9 +1419,7 @@ static void radeon_pm_fini_dpm(struct radeon_device *rdev)
> radeon_dpm_fini(rdev);
>
> radeon_hwmon_fini(rdev);
> -
> - if (rdev->pm.power_state)
> - kfree(rdev->pm.power_state);
> + kfree(rdev->pm.power_state);
> }
>
> void radeon_pm_fini(struct radeon_device *rdev)
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> http://lists.freedesktop.org/mailman/listinfo/dri-devel