2014-07-04 23:40:43

by Andrey Utkin

Subject: [PATCH] staging: rtl8192ee: Correct bitmask in comparsion

See https://bugzilla.kernel.org/show_bug.cgi?id=78041
---8<---
Reported-by: David Binderman <[email protected]>
Signed-off-by: Andrey Utkin <[email protected]>
---
drivers/staging/rtl8192ee/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192ee/base.c b/drivers/staging/rtl8192ee/base.c
index a7c69f7..71ed12e 100644
--- a/drivers/staging/rtl8192ee/base.c
+++ b/drivers/staging/rtl8192ee/base.c
@@ -827,7 +827,7 @@ static u8 _rtl_get_vht_highest_n_rate(struct ieee80211_hw *hw,
u16 map = le16_to_cpu(sta->vht_cap.vht_mcs.tx_mcs_map);

if ((get_rf_type(rtlphy) == RF_2T2R) &&
- (map & 0x000c) != 0x000c0) {
+ (map & 0x000c) != 0x000c) {
if ((map & 0x000c) >> 2 == IEEE80211_VHT_MCS_SUPPORT_0_7)
hw_rate =
rtlpriv->cfg->maps[RTL_RC_VHT_RATE_2SS_MCS7];
--
1.8.3.2

2014-07-08 11:49:16

by Dan Carpenter

Subject: Re: [PATCH] staging: rtl8192ee: Correct bitmask in comparsion

On Sat, Jul 05, 2014 at 02:40:13AM +0300, Andrey Utkin wrote:
> See https://bugzilla.kernel.org/show_bug.cgi?id=78041
> ---8<---
> Reported-by: David Binderman <[email protected]>
> Signed-off-by: Andrey Utkin <[email protected]>

Following the link to bugzilla, this is a static checker fix.

As far as I can see this patch is just based on guess work? Otherwise
put some kind of description why your fix is correct in the changelog.

regards,
dan carpenter