2014-07-06 18:43:21

by Rickard Strandqvist

Subject: [PATCH] video: fbdev: mxsfb.c: Cleaning up variable that is never used

Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <[email protected]>
---
drivers/video/fbdev/mxsfb.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/video/fbdev/mxsfb.c b/drivers/video/fbdev/mxsfb.c
index accf48a2..d0a55c6 100644
--- a/drivers/video/fbdev/mxsfb.c
+++ b/drivers/video/fbdev/mxsfb.c
@@ -594,7 +594,6 @@ static int mxsfb_restore_mode(struct mxsfb_info *host,
struct fb_videomode *vmode)
{
struct fb_info *fb_info = &host->fb_info;
- unsigned line_count;
unsigned period;
unsigned long pa, fbsize;
int bits_per_pixel, ofs;
@@ -672,7 +671,6 @@ static int mxsfb_restore_mode(struct mxsfb_info *host,
writel(fb_info->fix.smem_start, host->base + host->devdata->next_buf);
}

- line_count = fb_info->fix.smem_len / fb_info->fix.line_length;
fb_info->fix.ypanstep = 1;

clk_prepare_enable(host->clk);
--
1.7.10.4

2014-07-06 21:07:16

by Marek Vasut

Subject: Re: [PATCH] video: fbdev: mxsfb.c: Cleaning up variable that is never used

On Sunday, July 06, 2014 at 08:44:32 PM, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <[email protected]>

Makes perfect sense.

Acked-by: Marek Vasut <[email protected]>

Best regards,
Marek Vasut