2014-07-16 03:10:54

by Saravana Kannan

Subject: [PATCH] PM / devfreq: Allocate memory using the right data type

From: Suman Tatiraju <[email protected]>

Long and int have different sizes on a 64-bit machine. Allocate
memory for the time_in_state table using the right data type.

Change-Id: I335277674018c0ea759aa0996309d52578ea1fd5
Signed-off-by: Suman Tatiraju <[email protected]>
Reviewed-by: Saravana Kannan <[email protected]>
Signed-off-by: Saravana Kannan <[email protected]>
---
drivers/devfreq/devfreq.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 65eed38..349e28ea 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -483,9 +483,10 @@ struct devfreq *devfreq_add_device(struct device *dev,
devfreq->profile->max_state *
devfreq->profile->max_state,
GFP_KERNEL);
- devfreq->time_in_state = devm_kzalloc(dev, sizeof(unsigned int) *
- devfreq->profile->max_state,
- GFP_KERNEL);
+ devfreq->time_in_state = devm_kzalloc(dev,
+ sizeof(*(devfreq->time_in_state)) *
+ devfreq->profile->max_state,
+ GFP_KERNEL);
devfreq->last_stat_updated = jiffies;

dev_set_name(&devfreq->dev, "%s", dev_name(dev));
--
1.8.2.1

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

2014-07-16 03:29:12

by Greg Kroah-Hartman

Subject: Re: [PATCH] PM / devfreq: Allocate memory using the right data type

On Tue, Jul 15, 2014 at 08:10:43PM -0700, Saravana Kannan wrote:
> From: Suman Tatiraju <[email protected]>
>
> Long and int have different sizes on a 64-bit machine. Allocate
> memory for the time_in_state table using the right data type.
>
> Change-Id: I335277674018c0ea759aa0996309d52578ea1fd5

Please don't put this crud in patches you submit upstream. It means
nothing to us.

> Signed-off-by: Suman Tatiraju <[email protected]>
> Reviewed-by: Saravana Kannan <[email protected]>
> Signed-off-by: Saravana Kannan <[email protected]>
> ---
> drivers/devfreq/devfreq.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>

2014-07-16 17:21:21

by Stephen Boyd

Subject: Re: [PATCH] PM / devfreq: Allocate memory using the right data type

On 07/15/14 20:10, Saravana Kannan wrote:
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 65eed38..349e28ea 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -483,9 +483,10 @@ struct devfreq *devfreq_add_device(struct device *dev,
> devfreq->profile->max_state *
> devfreq->profile->max_state,
> GFP_KERNEL);
> - devfreq->time_in_state = devm_kzalloc(dev, sizeof(unsigned int) *
> - devfreq->profile->max_state,
> - GFP_KERNEL);
> + devfreq->time_in_state = devm_kzalloc(dev,
> + sizeof(*(devfreq->time_in_state)) *
> + devfreq->profile->max_state,
> + GFP_KERNEL);

We could use devm_kcalloc() here too.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation