2014-07-17 04:03:33

by Kiran Padwal

Subject: [PATCH] Staging: gdm724x: gdm_lte.c: fix missing blank line after variable declaration

Checkpatch fix - Add missing blank line after variable declaration

Signed-off-by: Kiran Padwal <[email protected]>
---
drivers/staging/gdm724x/gdm_lte.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
index 64c55b9..bc6d574 100644
--- a/drivers/staging/gdm724x/gdm_lte.c
+++ b/drivers/staging/gdm724x/gdm_lte.c
@@ -447,6 +447,7 @@ static int gdm_lte_tx(struct sk_buff *skb, struct net_device *dev)
*/
if (nic_type & NIC_TYPE_F_VLAN) {
struct vlan_ethhdr *vlan_eth = (struct vlan_ethhdr *)skb->data;
+
nic->vlan_id = ntohs(vlan_eth->h_vlan_TCI) & VLAN_VID_MASK;
data_buf = skb->data + (VLAN_ETH_HLEN - ETH_HLEN);
data_len = skb->len - (VLAN_ETH_HLEN - ETH_HLEN);
@@ -505,6 +506,7 @@ static int gdm_lte_tx(struct sk_buff *skb, struct net_device *dev)
static struct net_device_stats *gdm_lte_stats(struct net_device *dev)
{
struct nic *nic = netdev_priv(dev);
+
return &nic->stats;
}

--
1.7.9.5

2014-07-18 01:05:38

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: gdm724x: gdm_lte.c: fix missing blank line after variable declaration

On Thu, Jul 17, 2014 at 09:30:38AM +0530, Kiran Padwal wrote:
> Checkpatch fix - Add missing blank line after variable declaration
>
> Signed-off-by: Kiran Padwal <[email protected]>
> ---
> drivers/staging/gdm724x/gdm_lte.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
> index 64c55b9..bc6d574 100644
> --- a/drivers/staging/gdm724x/gdm_lte.c
> +++ b/drivers/staging/gdm724x/gdm_lte.c
> @@ -447,6 +447,7 @@ static int gdm_lte_tx(struct sk_buff *skb, struct net_device *dev)
> */
> if (nic_type & NIC_TYPE_F_VLAN) {
> struct vlan_ethhdr *vlan_eth = (struct vlan_ethhdr *)skb->data;
> +
> nic->vlan_id = ntohs(vlan_eth->h_vlan_TCI) & VLAN_VID_MASK;
> data_buf = skb->data + (VLAN_ETH_HLEN - ETH_HLEN);
> data_len = skb->len - (VLAN_ETH_HLEN - ETH_HLEN);
> @@ -505,6 +506,7 @@ static int gdm_lte_tx(struct sk_buff *skb, struct net_device *dev)
> static struct net_device_stats *gdm_lte_stats(struct net_device *dev)
> {
> struct nic *nic = netdev_priv(dev);
> +
> return &nic->stats;
> }
>

Someone else sent me this same patch back in May, and it's in my tree.
Please always work against linux-next, or my staging-next branch of my
staging.git tree if you want to send me patches like this.

thanks,

greg k-h