2014-07-17 12:13:40

by Andrey Utkin

Subject: [PATCH 1/3] drivers/ata/pata_ep93xx.c: use signed int type for result of platform_get_irq()

[linux-3.16-rc5/drivers/ata/pata_ep93xx.c:929]: (style) Checking if unsigned
variable 'irq' is less than zero.

Source code is

irq = platform_get_irq(pdev, 0);
if (irq < 0) {

but

unsigned int irq;

$ fgrep platform_get_irq `find . -name \*.h -print`
./include/linux/platform_device.h:extern int platform_get_irq(struct
platform_device *, unsigned int);

Now using "int" type instead of "unsigned int" for "irq" variable.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80401
Reported-by: David Binderman <[email protected]>
Signed-off-by: Andrey Utkin <[email protected]>
---
drivers/ata/pata_ep93xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c
index 6ad5c07..4d37c54 100644
--- a/drivers/ata/pata_ep93xx.c
+++ b/drivers/ata/pata_ep93xx.c
@@ -915,7 +915,7 @@ static int ep93xx_pata_probe(struct platform_device *pdev)
struct ep93xx_pata_data *drv_data;
struct ata_host *host;
struct ata_port *ap;
- unsigned int irq;
+ int irq;
struct resource *mem_res;
void __iomem *ide_base;
int err;
--
1.8.5.5

2014-07-17 12:36:52

by Tejun Heo

Subject: Re: [PATCH 1/3] drivers/ata/pata_ep93xx.c: use signed int type for result of platform_get_irq()

On Thu, Jul 17, 2014 at 03:13:23PM +0300, Andrey Utkin wrote:
> [linux-3.16-rc5/drivers/ata/pata_ep93xx.c:929]: (style) Checking if unsigned
> variable 'irq' is less than zero.
>
> Source code is
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
>
> but
>
> unsigned int irq;
>
> $ fgrep platform_get_irq `find . -name \*.h -print`
> ./include/linux/platform_device.h:extern int platform_get_irq(struct
> platform_device *, unsigned int);
>
> Now using "int" type instead of "unsigned int" for "irq" variable.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80401
> Reported-by: David Binderman <[email protected]>
> Signed-off-by: Andrey Utkin <[email protected]>

Applied to libata/for-3.16-fixes.

Thanks.

--
tejun