2014-07-17 13:54:51

by Andrey Utkin

[permalink] [raw]
Subject: [PATCH 2/4] drivers/message/i2o/i2o_block.c: drop negativity check of unsigned long arg

[linux-3.16-rc5/drivers/message/i2o/i2o_block.c:674]: (style) Checking if
unsigned variable 'arg' is less than zero.

Source code is

if (arg < 0 || arg > CACHE_SMARTFETCH)
break;
but

static int i2o_block_ioctl(struct block_device *bdev, fmode_t mode,
unsigned int cmd, unsigned long arg)

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80451
Reported-by: David Binderman <[email protected]>
Signed-off-by: Andrey Utkin <[email protected]>
---
drivers/message/i2o/i2o_block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/message/i2o/i2o_block.c b/drivers/message/i2o/i2o_block.c
index 6fc3866..2b684ec 100644
--- a/drivers/message/i2o/i2o_block.c
+++ b/drivers/message/i2o/i2o_block.c
@@ -671,7 +671,7 @@ static int i2o_block_ioctl(struct block_device *bdev, fmode_t mode,
break;
case BLKI2OSRSTRAT:
ret = -EINVAL;
- if (arg < 0 || arg > CACHE_SMARTFETCH)
+ if (arg > CACHE_SMARTFETCH)
break;
dev->rcache = arg;
ret = 0;
--
1.8.5.5