2014-07-18 12:04:23

by Sachin Kamat

Subject: [PATCH 1/2 Resend] mfd: htc-i2cpld: Remove unused code

Removed code unused in this function.

Signed-off-by: Sachin Kamat <[email protected]>
Cc: Cory Maccarrone <[email protected]>
---
Compile tested.
---
drivers/mfd/htc-i2cpld.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c
index d7b2a75aca3e..b44f0203983b 100644
--- a/drivers/mfd/htc-i2cpld.c
+++ b/drivers/mfd/htc-i2cpld.c
@@ -332,18 +332,13 @@ static int htcpld_setup_chip_irq(
int chip_index)
{
struct htcpld_data *htcpld;
- struct device *dev = &pdev->dev;
- struct htcpld_core_platform_data *pdata;
struct htcpld_chip *chip;
- struct htcpld_chip_platform_data *plat_chip_data;
unsigned int irq, irq_end;
int ret = 0;

/* Get the platform and driver data */
- pdata = dev_get_platdata(dev);
htcpld = platform_get_drvdata(pdev);
chip = &htcpld->chip[chip_index];
- plat_chip_data = &pdata->chip[chip_index];

/* Setup irq handlers */
irq_end = chip->irq_start + chip->nirqs;
--
1.7.9.5

2014-07-18 12:04:28

by Sachin Kamat

Subject: [PATCH Resend 2/2] mfd: tps65912-spi: Remove unused variable

‘rx_buf’ is not used in this function.

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/mfd/tps65912-spi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mfd/tps65912-spi.c b/drivers/mfd/tps65912-spi.c
index 69a5178bf152..de60ad98bd9f 100644
--- a/drivers/mfd/tps65912-spi.c
+++ b/drivers/mfd/tps65912-spi.c
@@ -32,10 +32,9 @@ static int tps65912_spi_write(struct tps65912 *tps65912, u8 addr,
unsigned long spi_data = 1 << 23 | addr << 15 | *data;
struct spi_transfer xfer;
struct spi_message msg;
- u32 tx_buf, rx_buf;
+ u32 tx_buf;

tx_buf = spi_data;
- rx_buf = 0;

xfer.tx_buf = &tx_buf;
xfer.rx_buf = NULL;
--
1.7.9.5

2014-07-28 06:54:26

by Lee Jones

Subject: Re: [PATCH 1/2 Resend] mfd: htc-i2cpld: Remove unused code

On Fri, 18 Jul 2014, Sachin Kamat wrote:

> Removed code unused in this function.
>
> Signed-off-by: Sachin Kamat <[email protected]>
> Cc: Cory Maccarrone <[email protected]>
> ---
> Compile tested.
> ---
> drivers/mfd/htc-i2cpld.c | 5 -----
> 1 file changed, 5 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c
> index d7b2a75aca3e..b44f0203983b 100644
> --- a/drivers/mfd/htc-i2cpld.c
> +++ b/drivers/mfd/htc-i2cpld.c
> @@ -332,18 +332,13 @@ static int htcpld_setup_chip_irq(
> int chip_index)
> {
> struct htcpld_data *htcpld;
> - struct device *dev = &pdev->dev;
> - struct htcpld_core_platform_data *pdata;
> struct htcpld_chip *chip;
> - struct htcpld_chip_platform_data *plat_chip_data;
> unsigned int irq, irq_end;
> int ret = 0;
>
> /* Get the platform and driver data */
> - pdata = dev_get_platdata(dev);
> htcpld = platform_get_drvdata(pdev);
> chip = &htcpld->chip[chip_index];
> - plat_chip_data = &pdata->chip[chip_index];
>
> /* Setup irq handlers */
> irq_end = chip->irq_start + chip->nirqs;

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

2014-07-28 06:54:47

by Lee Jones

Subject: Re: [PATCH Resend 2/2] mfd: tps65912-spi: Remove unused variable

On Fri, 18 Jul 2014, Sachin Kamat wrote:

> ‘rx_buf’ is not used in this function.
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> drivers/mfd/tps65912-spi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/tps65912-spi.c b/drivers/mfd/tps65912-spi.c
> index 69a5178bf152..de60ad98bd9f 100644
> --- a/drivers/mfd/tps65912-spi.c
> +++ b/drivers/mfd/tps65912-spi.c
> @@ -32,10 +32,9 @@ static int tps65912_spi_write(struct tps65912 *tps65912, u8 addr,
> unsigned long spi_data = 1 << 23 | addr << 15 | *data;
> struct spi_transfer xfer;
> struct spi_message msg;
> - u32 tx_buf, rx_buf;
> + u32 tx_buf;
>
> tx_buf = spi_data;
> - rx_buf = 0;
>
> xfer.tx_buf = &tx_buf;
> xfer.rx_buf = NULL;

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog