2014-07-18 15:32:14

by Andrey Utkin

Subject: [PATCH 2/5] net/rxrpc/ar-key.c: drop negativity check on unsigned value

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80611
Reported-by: David Binderman <[email protected]>
Signed-off-by: Andrey Utkin <[email protected]>
---
net/rxrpc/ar-key.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/rxrpc/ar-key.c b/net/rxrpc/ar-key.c
index 0ad0807..eec998e 100644
--- a/net/rxrpc/ar-key.c
+++ b/net/rxrpc/ar-key.c
@@ -346,7 +346,7 @@ static int rxrpc_krb5_decode_tagged_array(struct krb5_tagged_data **_td,

n_elem = ntohl(*xdr++);
toklen -= 4;
- if (n_elem < 0 || n_elem > max_n_elem)
+ if (n_elem > max_n_elem)
return -EINVAL;
*_n_elem = n_elem;
if (n_elem > 0) {
--
1.8.5.5

2014-07-21 04:26:15

by David Miller

Subject: Re: [PATCH 2/5] net/rxrpc/ar-key.c: drop negativity check on unsigned value

From: Andrey Utkin <[email protected]>
Date: Fri, 18 Jul 2014 18:31:57 +0300

> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80611
> Reported-by: David Binderman <[email protected]>
> Signed-off-by: Andrey Utkin <[email protected]>

Applied to net-next, thanks.