2014-07-18 15:35:37

by Andrey Utkin

Subject: [PATCH 5/5] fs/ubifs/{sb,super}.c: drop negativity check on unsigned value

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80581
Reported-by: David Binderman <[email protected]>
Signed-off-by: Andrey Utkin <[email protected]>
---
fs/ubifs/sb.c | 2 +-
fs/ubifs/super.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ubifs/sb.c b/fs/ubifs/sb.c
index 4c37607..c2c3d13 100644
--- a/fs/ubifs/sb.c
+++ b/fs/ubifs/sb.c
@@ -447,7 +447,7 @@ static int validate_sb(struct ubifs_info *c, struct ubifs_sb_node *sup)
goto failed;
}

- if (c->default_compr < 0 || c->default_compr >= UBIFS_COMPR_TYPES_CNT) {
+ if (c->default_compr >= UBIFS_COMPR_TYPES_CNT) {
err = 13;
goto failed;
}
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index e5bd068..9c59c10 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -75,7 +75,7 @@ static int validate_inode(struct ubifs_info *c, const struct inode *inode)
return 1;
}

- if (ui->compr_type < 0 || ui->compr_type >= UBIFS_COMPR_TYPES_CNT) {
+ if (ui->compr_type >= UBIFS_COMPR_TYPES_CNT) {
ubifs_err("unknown compression type %d", ui->compr_type);
return 2;
}
--
1.8.5.5

2014-07-19 09:23:40

by Artem Bityutskiy

Subject: Re: [PATCH 5/5] fs/ubifs/{sb,super}.c: drop negativity check on unsigned value

On Fri, 2014-07-18 at 18:35 +0300, Andrey Utkin wrote:
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80581
> Reported-by: David Binderman <[email protected]>
> Signed-off-by: Andrey Utkin <[email protected]>

Hi, thanks, but I already have a patch which does the same in the
linux-ubifs.git tree:

commit b793a8c8885d87d9867fb2dbfdc1ef7b5877d71b
Author: hujianyang <[email protected]>
Date: Wed Jun 11 10:42:52 2014 +0800

UBIFS: remove useless statements

This patch removes useless and duplicate statements.

Signed-off-by: hujianyang <[email protected]>
Signed-off-by: Artem Bityutskiy <[email protected]>

--
Best Regards,
Artem Bityutskiy