2014-07-23 15:00:34

by Alexandre Courbot

Subject: [PATCH] gpio: remove useless check in gpiolib_sysfs_init()

An iterator variable cannot be NULL in its loop.

Reported-by: Julia Lawall <[email protected]>
Signed-off-by: Alexandre Courbot <[email protected]>
---
drivers/gpio/gpiolib-sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c
index 3516502..bcc0ec0 100644
--- a/drivers/gpio/gpiolib-sysfs.c
+++ b/drivers/gpio/gpiolib-sysfs.c
@@ -814,7 +814,7 @@ static int __init gpiolib_sysfs_init(void)
*/
spin_lock_irqsave(&gpio_lock, flags);
list_for_each_entry(chip, &gpio_chips, list) {
- if (!chip || chip->exported)
+ if (chip->exported)
continue;

spin_unlock_irqrestore(&gpio_lock, flags);
--
2.0.2

2014-07-24 14:04:12

by Linus Walleij

Subject: Re: [PATCH] gpio: remove useless check in gpiolib_sysfs_init()

On Wed, Jul 23, 2014 at 4:56 PM, Alexandre Courbot <[email protected]> wrote:

> An iterator variable cannot be NULL in its loop.
>
> Reported-by: Julia Lawall <[email protected]>
> Signed-off-by: Alexandre Courbot <[email protected]>

Patch applied.

Yours,
Linus Walleij