2014-07-30 11:59:29

by Alexander Popov

Subject: [PATCH 1/1] dmaengine: of: kconfig: select DMA_ENGINE when DMA_OF is selected

Select DMA_ENGINE when DMA_OF is selected since
of_dma_xlate_by_chan_id() from drivers/dma/of-dma.c uses
dma_get_slave_channel() from drivers/dma/dmaengine.c

Signed-off-by: Alexander Popov <[email protected]>
---
drivers/dma/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 1eca7b9..f887b19 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -388,6 +388,7 @@ config DMA_ACPI
config DMA_OF
def_bool y
depends on OF
+ select DMA_ENGINE

comment "DMA Clients"
depends on DMA_ENGINE
--
1.8.4.2

2014-07-30 13:46:34

by Vinod Koul

Subject: Re: [PATCH 1/1] dmaengine: of: kconfig: select DMA_ENGINE when DMA_OF is selected

On Wed, Jul 30, 2014 at 03:58:51PM +0400, Alexander Popov wrote:
> Select DMA_ENGINE when DMA_OF is selected since
> of_dma_xlate_by_chan_id() from drivers/dma/of-dma.c uses
> dma_get_slave_channel() from drivers/dma/dmaengine.c
>
Please give credit to reporter by adding "Reported-by:" tag in commit

It is also got practice to give error log
> Signed-off-by: Alexander Popov <[email protected]>

Applied, now after adding reported tag and error log

--
~Vinod
> ---
> drivers/dma/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 1eca7b9..f887b19 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -388,6 +388,7 @@ config DMA_ACPI
> config DMA_OF
> def_bool y
> depends on OF
> + select DMA_ENGINE
>
> comment "DMA Clients"
> depends on DMA_ENGINE
> --
> 1.8.4.2
>

--

2014-07-30 14:12:24

by Alexander Popov

Subject: Re: [PATCH 1/1] dmaengine: of: kconfig: select DMA_ENGINE when DMA_OF is selected

2014-07-30 17:38 GMT+04:00 Vinod Koul <[email protected]>:
> On Wed, Jul 30, 2014 at 03:58:51PM +0400, Alexander Popov wrote:
>> Select DMA_ENGINE when DMA_OF is selected since
>> of_dma_xlate_by_chan_id() from drivers/dma/of-dma.c uses
>> dma_get_slave_channel() from drivers/dma/dmaengine.c
>>
> Please give credit to reporter by adding "Reported-by:" tag in commit
> It is also got practice to give error log
Ok, I got it.

>> Signed-off-by: Alexander Popov <[email protected]>
> Applied, now after adding reported tag and error log
Thanks, Vinod.

Best regards,
Alexander