2014-10-01 09:59:27

by Michael Opdenacker

[permalink] [raw]
Subject: [PATCH] ARC: [plat-arcfpga]: remove unused Kconfig params

This removes the ARC_BOARD_ANGEL4 and ARC_BOARD_ML509
Kconfig parameters which are no longer used anywhere
in the source code and Makefiles.

This also updates a comment refering to these parameters.

Signed-off-by: Michael Opdenacker <[email protected]>
---
arch/arc/plat-arcfpga/Kconfig | 13 -------------
1 file changed, 13 deletions(-)

diff --git a/arch/arc/plat-arcfpga/Kconfig b/arch/arc/plat-arcfpga/Kconfig
index b9f34cf55acf..3f6814aa97ac 100644
--- a/arch/arc/plat-arcfpga/Kconfig
+++ b/arch/arc/plat-arcfpga/Kconfig
@@ -12,23 +12,10 @@ menuconfig ARC_PLAT_FPGA_LEGACY
help
Support for ARC development boards, provided by Synopsys.
These are based on FPGA or ISS. e.g.
- - ARCAngel4
- - ML509
- MetaWare ISS

if ARC_PLAT_FPGA_LEGACY

-config ARC_BOARD_ANGEL4
- bool "ARC Angel4"
- default y
- help
- ARC Angel4 FPGA Ref Platform (Xilinx Virtex Based)
-
-config ARC_BOARD_ML509
- bool "ML509"
- help
- ARC ML509 FPGA Ref Platform (Xilinx Virtex-5 Based)
-
config ISS_SMP_EXTN
bool "ARC SMP Extensions (ISS Models only)"
default n
--
1.9.1


2014-10-01 10:12:11

by Paul Bolle

[permalink] [raw]
Subject: Re: [PATCH] ARC: [plat-arcfpga]: remove unused Kconfig params

On Wed, 2014-10-01 at 11:59 +0200, Michael Opdenacker wrote:
> This removes the ARC_BOARD_ANGEL4 and ARC_BOARD_ML509
> Kconfig parameters which are no longer used anywhere
> in the source code and Makefiles.
>
> This also updates a comment refering to these parameters.
>
> Signed-off-by: Michael Opdenacker <[email protected]>
> ---

See commit 774b689502d4 ("ARC: [arcfpga] Get rid of ARC_BOARD_ANGEL4 and
ARC_BOARD_ML509") in linux-next since yesterday.

> arch/arc/plat-arcfpga/Kconfig | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/arch/arc/plat-arcfpga/Kconfig b/arch/arc/plat-arcfpga/Kconfig
> index b9f34cf55acf..3f6814aa97ac 100644
> --- a/arch/arc/plat-arcfpga/Kconfig
> +++ b/arch/arc/plat-arcfpga/Kconfig
> @@ -12,23 +12,10 @@ menuconfig ARC_PLAT_FPGA_LEGACY
> help
> Support for ARC development boards, provided by Synopsys.
> These are based on FPGA or ISS. e.g.
> - - ARCAngel4
> - - ML509
> - MetaWare ISS

It doesn't follow from the fact that these Kconfig symbols are unused
that this help text is now incorrect. How did you establish that?

> if ARC_PLAT_FPGA_LEGACY
>
> -config ARC_BOARD_ANGEL4
> - bool "ARC Angel4"
> - default y
> - help
> - ARC Angel4 FPGA Ref Platform (Xilinx Virtex Based)
> -
> -config ARC_BOARD_ML509
> - bool "ML509"
> - help
> - ARC ML509 FPGA Ref Platform (Xilinx Virtex-5 Based)
> -
> config ISS_SMP_EXTN
> bool "ARC SMP Extensions (ISS Models only)"
> default n


Paul Bolle

2014-10-02 20:02:27

by Michael Opdenacker

[permalink] [raw]
Subject: Re: [PATCH] ARC: [plat-arcfpga]: remove unused Kconfig params

Hi Paul,

Thank you for reviewing my patch!

On 10/01/2014 12:12 PM, Paul Bolle wrote:
> On Wed, 2014-10-01 at 11:59 +0200, Michael Opdenacker wrote:
>> This removes the ARC_BOARD_ANGEL4 and ARC_BOARD_ML509
>> Kconfig parameters which are no longer used anywhere
>> in the source code and Makefiles.
>>
>> This also updates a comment refering to these parameters.
>>
>> Signed-off-by: Michael Opdenacker <[email protected]>
>> ---
> See commit 774b689502d4 ("ARC: [arcfpga] Get rid of ARC_BOARD_ANGEL4 and
> ARC_BOARD_ML509") in linux-next since yesterday.

Great. Happy to drop my patch then!

>
>> arch/arc/plat-arcfpga/Kconfig | 13 -------------
>> 1 file changed, 13 deletions(-)
>>
>> diff --git a/arch/arc/plat-arcfpga/Kconfig b/arch/arc/plat-arcfpga/Kconfig
>> index b9f34cf55acf..3f6814aa97ac 100644
>> --- a/arch/arc/plat-arcfpga/Kconfig
>> +++ b/arch/arc/plat-arcfpga/Kconfig
>> @@ -12,23 +12,10 @@ menuconfig ARC_PLAT_FPGA_LEGACY
>> help
>> Support for ARC development boards, provided by Synopsys.
>> These are based on FPGA or ISS. e.g.
>> - - ARCAngel4
>> - - ML509
>> - MetaWare ISS
> It doesn't follow from the fact that these Kconfig symbols are unused
> that this help text is now incorrect. How did you establish that?

Oops, you're definitely right. Pfooh, starting to make the confusion
between data and metadata... scary.

Cheers,

Michael.

--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098