2014-10-01 10:43:03

by Pramod Gurav

Subject: [PATCH] gpio: Switch to using managed resources with devm_

This change switches to devm_request_region to request region
and hence simplifies the module unload and does away with
release_region in remove function.

Cc: Linus Walleij <[email protected]>
Cc: Alexandre Courbot <[email protected]>
Cc: [email protected]
Signed-off-by: Pramod Gurav <[email protected]>
---
drivers/gpio/gpio-cs5535.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/gpio/gpio-cs5535.c b/drivers/gpio/gpio-cs5535.c
index 92ec58f..802d518 100644
--- a/drivers/gpio/gpio-cs5535.c
+++ b/drivers/gpio/gpio-cs5535.c
@@ -319,7 +319,8 @@ static int cs5535_gpio_probe(struct platform_device *pdev)
goto done;
}

- if (!request_region(res->start, resource_size(res), pdev->name)) {
+ if (!devm_request_region(&pdev->dev, res->start, resource_size(res),
+ pdev->name)) {
dev_err(&pdev->dev, "can't request region\n");
goto done;
}
@@ -345,24 +346,18 @@ static int cs5535_gpio_probe(struct platform_device *pdev)
/* finally, register with the generic GPIO API */
err = gpiochip_add(&cs5535_gpio_chip.chip);
if (err)
- goto release_region;
+ goto done;

return 0;

-release_region:
- release_region(res->start, resource_size(res));
done:
return err;
}

static int cs5535_gpio_remove(struct platform_device *pdev)
{
- struct resource *r;
-
gpiochip_remove(&cs5535_gpio_chip.chip);

- r = platform_get_resource(pdev, IORESOURCE_IO, 0);
- release_region(r->start, resource_size(r));
return 0;
}

--
1.7.9.5

2014-10-05 10:29:20

by Alexandre Courbot

Subject: Re: [PATCH] gpio: Switch to using managed resources with devm_

On Wed, Oct 1, 2014 at 7:46 PM, Pramod Gurav
<[email protected]> wrote:
> This change switches to devm_request_region to request region
> and hence simplifies the module unload and does away with
> release_region in remove function.

Your subject line should probably start with "gpio: cs5535:"

Otherwise,

Reviewed-by: Alexandre Courbot <[email protected]>

2014-10-21 08:52:16

by Linus Walleij

Subject: Re: [PATCH] gpio: Switch to using managed resources with devm_

On Wed, Oct 1, 2014 at 12:46 PM, Pramod Gurav
<[email protected]> wrote:

> This change switches to devm_request_region to request region
> and hence simplifies the module unload and does away with
> release_region in remove function.
>
> Cc: Linus Walleij <[email protected]>
> Cc: Alexandre Courbot <[email protected]>
> Cc: [email protected]
> Signed-off-by: Pramod Gurav <[email protected]>

Patch applied with augmented subject.

Yours,
Linus Walleij

2014-10-21 09:00:55

by Pramod Gurav

Subject: Re: [PATCH] gpio: Switch to using managed resources with devm_

On Tue, Oct 21, 2014 at 2:22 PM, Linus Walleij <[email protected]> wrote:
> On Wed, Oct 1, 2014 at 12:46 PM, Pramod Gurav
> <[email protected]> wrote:
>
>> This change switches to devm_request_region to request region
>> and hence simplifies the module unload and does away with
>> release_region in remove function.
>>
>> Cc: Linus Walleij <[email protected]>
>> Cc: Alexandre Courbot <[email protected]>
>> Cc: [email protected]
>> Signed-off-by: Pramod Gurav <[email protected]>
>
> Patch applied with augmented subject.

Had sent v2 of this with change in subject. But thanks for the manual
change and applying.
>
> Yours,
> Linus Walleij
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/



--
Thanks and Regards
Pramod