Patchset documents correct and the deprecated vendor-prefix found by checkpatch
warning and also documents information of device isl29028 for compatibility.
Patchset also includes corrected vendor-prefix and device name in compatible
property for files with checkpatch warning of undocumented string "isil,isl29028".
Darshana Padmadas (4):
Documentation: devicetree: bindings: Document correct and deprecated
vendor-prefix with device isl29028
Documentation: devicetree: bindings: Document deprecated device vendor
name to fix related warning
Staging: iio: light: Added correct vendor-prefix for device isl29028
arch: arm: boot: dts: Added correct vendor-prefix with device name to
compatible property
Changes in v4:
- In PATCH 1/4 gave appropriate description for string describing vendor/chip
for deprecated vendor-prefix and device.
Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 ++
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +-
drivers/staging/iio/light/isl29028.c | 3 ++-
4 files changed, 6 insertions(+), 2 deletions(-)
--
1.9.1
This patch documents the device isl29028 with its vendor-prefix. Undocumented deprecated vendor-prefix
found by checkpatch also documented for compatibility reasons.
Signed-off-by: Darshana Padmadas <[email protected]>
---
Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
index 6af570e..32edf0b 100644
--- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
+++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
@@ -57,6 +57,8 @@ gmt,g751 G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire In
infineon,slb9635tt Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz)
infineon,slb9645tt Infineon SLB9645 I2C TPM (new protocol, max 400khz)
isl,isl12057 Intersil ISL12057 I2C RTC Chip
+isil,isl29028 (deprecated, use isl)
+isl,isl29028 Intersil ISL29028 Ambient Light and Proximity Sensor
maxim,ds1050 5 Bit Programmable, Pulse-Width Modulator
maxim,max1237 Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs
maxim,max6625 9-Bit/12-Bit Temperature Sensors with I²C-Compatible Serial Interface
--
1.9.1
This patch documents deprecated vendor name of device isl29028 for compatibility with older kernels.
Signed-off-by: Darshana Padmadas <[email protected]>
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index ac7269f..ab97459 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -68,6 +68,7 @@ img Imagination Technologies Ltd.
intel Intel Corporation
intercontrol Inter Control Group
isee ISEE 2007 S.L.
+isil Intersil (deprecated, use isl)
isl Intersil
karo Ka-Ro electronics GmbH
keymile Keymile GmbH
--
1.9.1
This patch adds the correct vendor-prefix for device isl29028 and
maintains deprecated vendor-prefix found by checkpatch warning
for older kernel releases.
Signed-off-by: Darshana Padmadas <[email protected]>
---
drivers/staging/iio/light/isl29028.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
index 6014625..e969107 100644
--- a/drivers/staging/iio/light/isl29028.c
+++ b/drivers/staging/iio/light/isl29028.c
@@ -537,7 +537,8 @@ static const struct i2c_device_id isl29028_id[] = {
MODULE_DEVICE_TABLE(i2c, isl29028_id);
static const struct of_device_id isl29028_of_match[] = {
- { .compatible = "isil,isl29028", },
+ { .compatible = "isl,isl29028", },
+ { .compatible = "isil,isl29028", },/* deprecated, don't use */
{ },
};
MODULE_DEVICE_TABLE(of, isl29028_of_match);
--
1.9.1
This patch adds the correct vendor-prefix listed in Documentation/devicetree/bindings/vendor-prefixes.txt
with the device name to compatible property.
Signed-off-by: Darshana Padmadas <[email protected]>
---
arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
index 2063795..dcc6c75 100644
--- a/arch/arm/boot/dts/tegra30-cardhu.dtsi
+++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi
@@ -187,7 +187,7 @@
/* ALS and Proximity sensor */
isl29028@44 {
- compatible = "isil,isl29028";
+ compatible = "isl,isl29028";
reg = <0x44>;
interrupt-parent = <&gpio>;
interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;
--
1.9.1
Hi Darshana,
On Tue, Oct 07, 2014 at 04:19:26PM +0100, Darshana Padmadas wrote:
> This patch documents the device isl29028 with its vendor-prefix. Undocumented deprecated vendor-prefix
> found by checkpatch also documented for compatibility reasons.
>
> Signed-off-by: Darshana Padmadas <[email protected]>
In future, when you receive an Acked-by (or Reviewed-by, Tested-by,
etc), please add them here for subsequent postings, unless there have
been substantial changes that mean said tags are not representative. For
example, this patch you should have:
Signed-off-by: Darshana Padmadas <[email protected]>
Acked-by: Arnd Bergmann <[email protected]>
Acked-by: Mark Rutland <[email protected]>
That makes it obvious that others have looked at your patches, and will
help maintainers when deciding whether to pick them up. Additionally,
for those who have reviewed or tested patches, it gains them some
recognition for that effort.
Additionally, it's generally a good idea to wait for at least a day or
so between postings so as to give others time to inspect patches.
Thanks,
Mark.
> ---
> Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> index 6af570e..32edf0b 100644
> --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> @@ -57,6 +57,8 @@ gmt,g751 G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire In
> infineon,slb9635tt Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz)
> infineon,slb9645tt Infineon SLB9645 I2C TPM (new protocol, max 400khz)
> isl,isl12057 Intersil ISL12057 I2C RTC Chip
> +isil,isl29028 (deprecated, use isl)
> +isl,isl29028 Intersil ISL29028 Ambient Light and Proximity Sensor
> maxim,ds1050 5 Bit Programmable, Pulse-Width Modulator
> maxim,max1237 Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs
> maxim,max6625 9-Bit/12-Bit Temperature Sensors with I²C-Compatible Serial Interface
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Tue, Oct 7, 2014 at 10:19 AM, Darshana Padmadas
<[email protected]> wrote:
> This patch adds the correct vendor-prefix listed in Documentation/devicetree/bindings/vendor-prefixes.txt
> with the device name to compatible property.
It would be nice if the subject and msg gave some clue as to which
binding and platform you are changing. Look at prior commits and
follow their pattern for subject.
Rob
>
> Signed-off-by: Darshana Padmadas <[email protected]>
> ---
> arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
> index 2063795..dcc6c75 100644
> --- a/arch/arm/boot/dts/tegra30-cardhu.dtsi
> +++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi
> @@ -187,7 +187,7 @@
>
> /* ALS and Proximity sensor */
> isl29028@44 {
> - compatible = "isil,isl29028";
> + compatible = "isl,isl29028";
> reg = <0x44>;
> interrupt-parent = <&gpio>;
> interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;
> --
> 1.9.1
>
On Tue, Oct 7, 2014 at 10:19 AM, Darshana Padmadas
<[email protected]> wrote:
> This patch documents deprecated vendor name of device isl29028 for compatibility with older kernels.
Fix your line wrapping to 72 chars.
You can shorten the subject "Documentation: devicetree: bindings:" to
"dt-bindings:". We're horribly inconsistent there...
Rob
> Signed-off-by: Darshana Padmadas <[email protected]>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index ac7269f..ab97459 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -68,6 +68,7 @@ img Imagination Technologies Ltd.
> intel Intel Corporation
> intercontrol Inter Control Group
> isee ISEE 2007 S.L.
> +isil Intersil (deprecated, use isl)
> isl Intersil
> karo Ka-Ro electronics GmbH
> keymile Keymile GmbH
> --
> 1.9.1
>
These probably should have been sent to [email protected]. Use
the maintainer.pl script.
regards,
dan carpenter
Hello.
On 10/8/2014 1:15 PM, Dan Carpenter wrote:
> These probably should have been sent to [email protected]. Use
> the maintainer.pl script.
You surely meant scripts/get_maintainer.pl. :-)
> regards,
> dan carpenter
WBR, Sergei
On 07/10/14 16:19, Darshana Padmadas wrote:
> This patch adds the correct vendor-prefix for device isl29028 and
> maintains deprecated vendor-prefix found by checkpatch warning
> for older kernel releases.
>
> Signed-off-by: Darshana Padmadas <[email protected]>
Acked-by: Jonathan Cameron <[email protected]>
Which tree does this series want to go through?
(I'm happy to take it via IIO once the outstanding issues are cleaned up
if no one else wants it).
> ---
> drivers/staging/iio/light/isl29028.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
> index 6014625..e969107 100644
> --- a/drivers/staging/iio/light/isl29028.c
> +++ b/drivers/staging/iio/light/isl29028.c
> @@ -537,7 +537,8 @@ static const struct i2c_device_id isl29028_id[] = {
> MODULE_DEVICE_TABLE(i2c, isl29028_id);
>
> static const struct of_device_id isl29028_of_match[] = {
> - { .compatible = "isil,isl29028", },
> + { .compatible = "isl,isl29028", },
> + { .compatible = "isil,isl29028", },/* deprecated, don't use */
> { },
> };
> MODULE_DEVICE_TABLE(of, isl29028_of_match);
>