2014-10-09 07:41:04

by Kiran Padwal

[permalink] [raw]
Subject: [PATCH 2/3] i2c: qup: Remove .owner field for driver

There is no need to init .owner field.

Based on the patch from Peter Griffin <[email protected]>
"mmc: remove .owner field for drivers using module_platform_driver"

This patch removes the superfluous .owner field for drivers which
use the module_platform_driver API, as this is overridden in
platform_driver_register anyway."

Signed-off-by: Kiran Padwal <[email protected]>
---
drivers/i2c/busses/i2c-qup.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
index 3a4d64e..f14af2e 100644
--- a/drivers/i2c/busses/i2c-qup.c
+++ b/drivers/i2c/busses/i2c-qup.c
@@ -760,7 +760,6 @@ static struct platform_driver qup_i2c_driver = {
.remove = qup_i2c_remove,
.driver = {
.name = "i2c_qup",
- .owner = THIS_MODULE,
.pm = &qup_i2c_qup_pm_ops,
.of_match_table = qup_i2c_dt_match,
},
--
1.7.9.5


2014-11-07 18:13:15

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH 2/3] i2c: qup: Remove .owner field for driver

On Thu, Oct 09, 2014 at 01:08:32PM +0530, Kiran Padwal wrote:
> There is no need to init .owner field.
>
> Based on the patch from Peter Griffin <[email protected]>
> "mmc: remove .owner field for drivers using module_platform_driver"
>
> This patch removes the superfluous .owner field for drivers which
> use the module_platform_driver API, as this is overridden in
> platform_driver_register anyway."
>
> Signed-off-by: Kiran Padwal <[email protected]>

Thanks, but superseded in favour of a generic solution
(https://lkml.org/lkml/2014/10/21/594).


Attachments:
(No filename) (574.00 B)
signature.asc (819.00 B)
Digital signature
Download all attachments