2014-10-16 13:08:12

by Johannes Thumshirn

Subject: [PATCH] hwmon: menf21bmc: Include linux/err.h

Include linux/err.h to get the definitions for IS_ERR() PTR_ERR() and
ERR_PTR() used in the driver.

This fixes compilation on powerpc targets.

Signed-off-by: Johannes Thumshirn <[email protected]>
---
drivers/hwmon/menf21bmc_hwmon.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hwmon/menf21bmc_hwmon.c b/drivers/hwmon/menf21bmc_hwmon.c
index c92229d..afc6b58 100644
--- a/drivers/hwmon/menf21bmc_hwmon.c
+++ b/drivers/hwmon/menf21bmc_hwmon.c
@@ -21,6 +21,7 @@
#include <linux/jiffies.h>
#include <linux/slab.h>
#include <linux/i2c.h>
+#include <linux/err.h>

#define DRV_NAME "menf21bmc_hwmon"

--
1.9.1

2014-10-16 13:18:59

by Guenter Roeck

Subject: Re: [PATCH] hwmon: menf21bmc: Include linux/err.h

On 10/16/2014 06:07 AM, Johannes Thumshirn wrote:
> Include linux/err.h to get the definitions for IS_ERR() PTR_ERR() and
> ERR_PTR() used in the driver.
>
> This fixes compilation on powerpc targets.
>
> Signed-off-by: Johannes Thumshirn <[email protected]>

Hmm, my build tests should really find that :-(

Applied, thanks

Guenter

> ---
> drivers/hwmon/menf21bmc_hwmon.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/menf21bmc_hwmon.c b/drivers/hwmon/menf21bmc_hwmon.c
> index c92229d..afc6b58 100644
> --- a/drivers/hwmon/menf21bmc_hwmon.c
> +++ b/drivers/hwmon/menf21bmc_hwmon.c
> @@ -21,6 +21,7 @@
> #include <linux/jiffies.h>
> #include <linux/slab.h>
> #include <linux/i2c.h>
> +#include <linux/err.h>
>
> #define DRV_NAME "menf21bmc_hwmon"
>
>