2014-10-17 03:48:31

by Martin Kelly

Subject: [PATCH] x86/xen: panic on bad Xen-provided memory map

Panic if Xen provides a memory map with 0 entries. Although this is
unlikely, it is better to catch the error at the point of seeing the map
than later on as a symptom of some other crash.

Signed-off-by: Martin Kelly <[email protected]>
---
arch/x86/xen/setup.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
index af72161..29834b3 100644
--- a/arch/x86/xen/setup.c
+++ b/arch/x86/xen/setup.c
@@ -595,6 +595,7 @@ char * __init xen_memory_setup(void)
rc = 0;
}
BUG_ON(rc);
+ BUG_ON(memmap.nr_entries == 0);

/*
* Xen won't allow a 1:1 mapping to be created to UNUSABLE
--
2.1.1

2014-10-17 12:46:15

by David Vrabel

Subject: Re: [Xen-devel] [PATCH] x86/xen: panic on bad Xen-provided memory map

On 17/10/14 04:48, Martin Kelly wrote:
> Panic if Xen provides a memory map with 0 entries. Although this is
> unlikely, it is better to catch the error at the point of seeing the map
> than later on as a symptom of some other crash.

Applied, thanks.

David