2014-10-25 18:55:16

by Fabian Frédérick

[permalink] [raw]
Subject: [PATCH 1/1 net-next] xfrm: fix set but not used warning in xfrm_policy_queue_process()

err was set but unused.

Signed-off-by: Fabian Frederick <[email protected]>
---
net/xfrm/xfrm_policy.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index 4c4e457..dc65324 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -1878,7 +1878,6 @@ xfrm_resolve_and_create_bundle(struct xfrm_policy **pols, int num_pols,

static void xfrm_policy_queue_process(unsigned long arg)
{
- int err = 0;
struct sk_buff *skb;
struct sock *sk;
struct dst_entry *dst;
@@ -1941,7 +1940,7 @@ static void xfrm_policy_queue_process(unsigned long arg)
skb_dst_drop(skb);
skb_dst_set(skb, dst);

- err = dst_output(skb);
+ dst_output(skb);
}

out:
--
1.9.3


2014-10-27 13:35:20

by Steffen Klassert

[permalink] [raw]
Subject: Re: [PATCH 1/1 net-next] xfrm: fix set but not used warning in xfrm_policy_queue_process()

On Sat, Oct 25, 2014 at 05:27:09PM +0200, Fabian Frederick wrote:
> err was set but unused.
>
> Signed-off-by: Fabian Frederick <[email protected]>

Applied to ipsec-next, thanks!