2014-10-27 15:23:13

by Dominik Dingel

Subject: [PATCH] KVM: trivial fix comment regarding __kvm_set_memory_region

commit 72dc67a69690 ("KVM: remove the usage of the mmap_sem for the protection of the memory slots.")
changed the lock which will be taken. This should be reflected in the function
commentary.

Signed-off-by: Dominik Dingel <[email protected]>
---
virt/kvm/kvm_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index d82ec25..8b13607 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -738,7 +738,7 @@ static struct kvm_memslots *install_new_memslots(struct kvm *kvm,
*
* Discontiguous memory is allowed, mostly for framebuffers.
*
- * Must be called holding mmap_sem for write.
+ * Must be called holding kvm->slots_lock for write.
*/
int __kvm_set_memory_region(struct kvm *kvm,
struct kvm_userspace_memory_region *mem)
--
1.8.5.5

2014-10-27 15:51:11

by Paolo Bonzini

Subject: Re: [PATCH] KVM: trivial fix comment regarding __kvm_set_memory_region

On 10/27/2014 04:22 PM, Dominik Dingel wrote:
> commit 72dc67a69690 ("KVM: remove the usage of the mmap_sem for the protection of the memory slots.")
> changed the lock which will be taken. This should be reflected in the function
> commentary.

Whoa, February 2008. :)

Thanks, applying this patch.

Paolo

> Signed-off-by: Dominik Dingel <[email protected]>
> ---
> virt/kvm/kvm_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index d82ec25..8b13607 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -738,7 +738,7 @@ static struct kvm_memslots *install_new_memslots(struct kvm *kvm,
> *
> * Discontiguous memory is allowed, mostly for framebuffers.
> *
> - * Must be called holding mmap_sem for write.
> + * Must be called holding kvm->slots_lock for write.
> */
> int __kvm_set_memory_region(struct kvm *kvm,
> struct kvm_userspace_memory_region *mem)
>