2014-10-27 19:55:17

by Fabian Frédérick

Subject: [PATCH V2 net-next] ipx: remove unnecessary casting on ntohl

use %08X instead of %08lX and remove casting.

Suggested-by: Joe Perches <[email protected]>
Signed-off-by: Fabian Frederick <[email protected]>
---
V2: remove casting instead of long unsigned int -> unsigned long
(suggested by Joe Perches)

net/ipx/ipx_proc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ipx/ipx_proc.c b/net/ipx/ipx_proc.c
index e15c16a..8391191 100644
--- a/net/ipx/ipx_proc.c
+++ b/net/ipx/ipx_proc.c
@@ -89,8 +89,8 @@ static int ipx_seq_route_show(struct seq_file *seq, void *v)

seq_printf(seq, "%08lX ", (unsigned long int)ntohl(rt->ir_net));
if (rt->ir_routed)
- seq_printf(seq, "%08lX %02X%02X%02X%02X%02X%02X\n",
- (long unsigned int)ntohl(rt->ir_intrfc->if_netnum),
+ seq_printf(seq, "%08X %02X%02X%02X%02X%02X%02X\n",
+ ntohl(rt->ir_intrfc->if_netnum),
rt->ir_router_node[0], rt->ir_router_node[1],
rt->ir_router_node[2], rt->ir_router_node[3],
rt->ir_router_node[4], rt->ir_router_node[5]);
--
1.9.1

2014-10-27 20:04:54

by David Miller

Subject: Re: [PATCH V2 net-next] ipx: remove unnecessary casting on ntohl

From: Fabian Frederick <[email protected]>
Date: Mon, 27 Oct 2014 20:55:08 +0100

> use %08X instead of %08lX and remove casting.
>
> Suggested-by: Joe Perches <[email protected]>
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
> V2: remove casting instead of long unsigned int -> unsigned long
> (suggested by Joe Perches)

Applied.