2014-10-29 22:33:05

by Mariusz Gorski

Subject: [PATCH] staging: panel: Use designated initializers

Fix "warning: missing initializer [-Wmissing-field-initializers]"
by using designated struct initializers.

Signed-off-by: Mariusz Gorski <[email protected]>
---
drivers/staging/panel/panel.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 6d1a320..98556ce 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -1375,9 +1375,9 @@ static const struct file_operations lcd_fops = {
};

static struct miscdevice lcd_dev = {
- LCD_MINOR,
- "lcd",
- &lcd_fops
+ .minor = LCD_MINOR,
+ .name = "lcd",
+ .fops = &lcd_fops,
};

/* public function usable from the kernel for any purpose */
@@ -1652,9 +1652,9 @@ static const struct file_operations keypad_fops = {
};

static struct miscdevice keypad_dev = {
- KEYPAD_MINOR,
- "keypad",
- &keypad_fops
+ .minor = KEYPAD_MINOR,
+ .name = "keypad",
+ .fops = &keypad_fops,
};

static void keypad_send_key(const char *string, int max_len)
--
2.1.2

2014-10-30 06:13:21

by Willy Tarreau

Subject: Re: [PATCH] staging: panel: Use designated initializers

Hi Mariusz,

On Wed, Oct 29, 2014 at 11:32:30PM +0100, Mariusz Gorski wrote:
> Fix "warning: missing initializer [-Wmissing-field-initializers]"
> by using designated struct initializers.
>
> Signed-off-by: Mariusz Gorski <[email protected]>

Acked-by: Willy Tarreau <[email protected]>

Thanks,
Willy