2014-11-05 06:10:00

by Wan Zongshun

Subject: [PATCH v3 3/3] mmc:sdhci-pci: enable sdhci doesn't support hs200 quirk for AMD sdhci

AMD SD controller supports the SDR104 mode, but caps2 can not
be promoted to support hs200 for eMMC.

Signed-off-by: Vincent Wan <[email protected]>
Signed-off-by: Wan Zongshun <[email protected]>
---
drivers/mmc/host/sdhci-pci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c
index 5a77f18..c1ecd20 100644
--- a/drivers/mmc/host/sdhci-pci.c
+++ b/drivers/mmc/host/sdhci-pci.c
@@ -652,8 +652,10 @@ static int amd_probe(struct sdhci_pci_chip *chip)
smbus_dev = pci_get_device(PCI_VENDOR_ID_AMD,
PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, NULL);

- if (smbus_dev && (smbus_dev->revision < 0x51))
+ if (smbus_dev && (smbus_dev->revision < 0x51)) {
chip->quirks2 |= SDHCI_QUIRK2_CLEAR_TRANSFERMODE_REG_BEFORE_CMD;
+ chip->quirks2 |= SDHCI_QUIRK2_BROKEN_HS200;
+ }

return 0;
}
--
1.8.1.2

2014-11-05 10:58:33

by Ulf Hansson

Subject: Re: [PATCH v3 3/3] mmc:sdhci-pci: enable sdhci doesn't support hs200 quirk for AMD sdhci

On 5 November 2014 07:09, Vincent Wan <[email protected]> wrote:
> AMD SD controller supports the SDR104 mode, but caps2 can not
> be promoted to support hs200 for eMMC.
>
> Signed-off-by: Vincent Wan <[email protected]>
> Signed-off-by: Wan Zongshun <[email protected]>

Thanks! Applied for next.

Kind regards
Uffe


> ---
> drivers/mmc/host/sdhci-pci.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c
> index 5a77f18..c1ecd20 100644
> --- a/drivers/mmc/host/sdhci-pci.c
> +++ b/drivers/mmc/host/sdhci-pci.c
> @@ -652,8 +652,10 @@ static int amd_probe(struct sdhci_pci_chip *chip)
> smbus_dev = pci_get_device(PCI_VENDOR_ID_AMD,
> PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, NULL);
>
> - if (smbus_dev && (smbus_dev->revision < 0x51))
> + if (smbus_dev && (smbus_dev->revision < 0x51)) {
> chip->quirks2 |= SDHCI_QUIRK2_CLEAR_TRANSFERMODE_REG_BEFORE_CMD;
> + chip->quirks2 |= SDHCI_QUIRK2_BROKEN_HS200;
> + }
>
> return 0;
> }
> --
> 1.8.1.2
>