2014-11-06 23:25:10

by Krzysztof Konopko

Subject: [PATCH 1/3] rtl8188eu: Fix FSF_MAILING_ADDRESS in rtw_led.*

rtw_led.* files include Free Software Foundation's mailing address in
the sample GPL notice. This is not desired and picked when running
scripts/checkpatch.pl.

Signed-off-by: Krzysztof Konopko <[email protected]>
---
drivers/staging/rtl8188eu/core/rtw_led.c | 4 ----
drivers/staging/rtl8188eu/include/rtw_led.h | 4 ----
2 files changed, 8 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers/staging/rtl8188eu/core/rtw_led.c
index 2aa6251..c6e8379 100644
--- a/drivers/staging/rtl8188eu/core/rtw_led.c
+++ b/drivers/staging/rtl8188eu/core/rtw_led.c
@@ -11,10 +11,6 @@
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
*
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
*
******************************************************************************/

diff --git a/drivers/staging/rtl8188eu/include/rtw_led.h b/drivers/staging/rtl8188eu/include/rtw_led.h
index dec8dbc..c49a9a1 100644
--- a/drivers/staging/rtl8188eu/include/rtw_led.h
+++ b/drivers/staging/rtl8188eu/include/rtw_led.h
@@ -11,10 +11,6 @@
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
*
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
*
******************************************************************************/
#ifndef __RTW_LED_H_
--
2.1.1

2014-11-06 23:25:15

by Krzysztof Konopko

Subject: [PATCH 2/3] rtl8188eu: Fix a typo in rtw_led.*

A rather obvious typo in one of the identifier has been found. This patch
fixes the typo and ensures any lines changed do not exceed 80 characters
as indicated by scripts/checkpatch.pl

Signed-off-by: Krzysztof Konopko <[email protected]>
---
drivers/staging/rtl8188eu/core/rtw_led.c | 6 ++++--
drivers/staging/rtl8188eu/include/rtw_led.h | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers/staging/rtl8188eu/core/rtw_led.c
index c6e8379..1b8264b 100644
--- a/drivers/staging/rtl8188eu/core/rtw_led.c
+++ b/drivers/staging/rtl8188eu/core/rtw_led.c
@@ -224,7 +224,8 @@ static void SwLedBlink1(struct LED_871x *pLed)
pLed->bLedWPSBlinkInProgress = false;
} else {
pLed->BlinkingLedState = RTW_LED_OFF;
- _set_timer(&(pLed->BlinkTimer), LED_BLINK_WPS_SUCESS_INTERVAL_ALPHA);
+ _set_timer(&(pLed->BlinkTimer),
+ LED_BLINK_WPS_SUCCESS_INTERVAL_ALPHA);
}
break;
default:
@@ -388,7 +389,8 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
pLed->CurrLedState = LED_BLINK_WPS_STOP;
if (pLed->bLedOn) {
pLed->BlinkingLedState = RTW_LED_OFF;
- _set_timer(&(pLed->BlinkTimer), LED_BLINK_WPS_SUCESS_INTERVAL_ALPHA);
+ _set_timer(&(pLed->BlinkTimer),
+ LED_BLINK_WPS_SUCCESS_INTERVAL_ALPHA);
} else {
pLed->BlinkingLedState = RTW_LED_ON;
_set_timer(&(pLed->BlinkTimer), 0);
diff --git a/drivers/staging/rtl8188eu/include/rtw_led.h b/drivers/staging/rtl8188eu/include/rtw_led.h
index c49a9a1..23f0cfe 100644
--- a/drivers/staging/rtl8188eu/include/rtw_led.h
+++ b/drivers/staging/rtl8188eu/include/rtw_led.h
@@ -23,7 +23,7 @@
#define LED_BLINK_LINK_INTERVAL_ALPHA 500 /* 500 */
#define LED_BLINK_SCAN_INTERVAL_ALPHA 180 /* 150 */
#define LED_BLINK_FASTER_INTERVAL_ALPHA 50
-#define LED_BLINK_WPS_SUCESS_INTERVAL_ALPHA 5000
+#define LED_BLINK_WPS_SUCCESS_INTERVAL_ALPHA 5000

enum LED_CTL_MODE {
LED_CTL_POWER_ON,
--
2.1.1

2014-11-06 23:26:04

by Krzysztof Konopko

Subject: [PATCH 3/3] rtl8188eu: Remove leading spaces in rtw_led.c

According to Linux coding convention leading spaces are not allowed. This
patch removes leading spaces in rtw_led.c

Signed-off-by: Krzysztof Konopko <[email protected]>
---
drivers/staging/rtl8188eu/core/rtw_led.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers/staging/rtl8188eu/core/rtw_led.c
index 1b8264b..5d7e8ec 100644
--- a/drivers/staging/rtl8188eu/core/rtw_led.c
+++ b/drivers/staging/rtl8188eu/core/rtw_led.c
@@ -40,6 +40,7 @@ void BlinkTimerCallback(void *data)
void BlinkWorkItemCallback(struct work_struct *work)
{
struct LED_871x *pLed = container_of(work, struct LED_871x, BlinkWorkItem);
+
BlinkHandler(pLed);
}

@@ -459,8 +460,8 @@ void LedControl8188eu(struct adapter *padapter, enum LED_CTL_MODE LedAction)
{
struct led_priv *ledpriv = &(padapter->ledpriv);

- if ((padapter->bSurpriseRemoved) || (padapter->bDriverStopped) ||
- (!padapter->hw_init_completed))
+ if ((padapter->bSurpriseRemoved) || (padapter->bDriverStopped) ||
+ (!padapter->hw_init_completed))
return;

if (!ledpriv->bRegUseLed)
--
2.1.1

2014-11-27 02:31:04

by Greg Kroah-Hartman

Subject: Re: [PATCH 3/3] rtl8188eu: Remove leading spaces in rtw_led.c

On Fri, Nov 07, 2014 at 12:24:28AM +0100, Krzysztof Konopko wrote:
> According to Linux coding convention leading spaces are not allowed. This
> patch removes leading spaces in rtw_led.c
>
> Signed-off-by: Krzysztof Konopko <[email protected]>
> ---
> drivers/staging/rtl8188eu/core/rtw_led.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers/staging/rtl8188eu/core/rtw_led.c
> index 1b8264b..5d7e8ec 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_led.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_led.c
> @@ -40,6 +40,7 @@ void BlinkTimerCallback(void *data)
> void BlinkWorkItemCallback(struct work_struct *work)
> {
> struct LED_871x *pLed = container_of(work, struct LED_871x, BlinkWorkItem);
> +
> BlinkHandler(pLed);
> }

This is not a "fix leading space" change :(