2014-11-08 17:23:11

by Darshana Padmadas

[permalink] [raw]
Subject: [PATCH v5 0/4] Correct vendor-prefix and document device isl29028

Patchset documents correct and the deprecated vendor-prefix found by checkpatch
warning and also documents information of device isl29028 for compatibility.
Patchset also includes corrected vendor-prefix and device name in compatible
property for files with checkpatch warning of undocumented string "isil,isl29028".

Darshana Padmadas (4):
dt-bindings: Document correct and deprecated vendor-prefix with device
isl29028
dt-bindings: Document deprecated device vendor name to fix related
warning
Staging: iio: light: Added correct vendor-prefix for device isl29028
arch: arm: boot: dts: Correct vendor-prefix for iio device isl29028 in
compatible property

Changes in v5:
- Shortened subject in PATCH 1/4 and PATCH 2/4.

Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 ++
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
drivers/staging/iio/light/isl29028.c | 3 ++-
arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +-
4 files changed, 6 insertions(+), 2 deletions(-)

--
1.9.1


2014-11-08 17:25:07

by Darshana Padmadas

[permalink] [raw]
Subject: [PATCH v5 1/4] dt-bindings: Document correct and deprecated vendor-prefix with device isl29028

This patch documents the device isl29028 with its vendor-prefix. Undocumented deprecated vendor-prefix
found by checkpatch also documented for compatibility reasons.

Signed-off-by: Darshana Padmadas <[email protected]>
Acked-by: Arnd Bergmann <[email protected]>
Acked-by: Mark Rutland <[email protected]>
---
Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
index 6af570e..32edf0b 100644
--- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
+++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
@@ -57,6 +57,8 @@ gmt,g751 G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire In
infineon,slb9635tt Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz)
infineon,slb9645tt Infineon SLB9645 I2C TPM (new protocol, max 400khz)
isl,isl12057 Intersil ISL12057 I2C RTC Chip
+isil,isl29028 (deprecated, use isl)
+isl,isl29028 Intersil ISL29028 Ambient Light and Proximity Sensor
maxim,ds1050 5 Bit Programmable, Pulse-Width Modulator
maxim,max1237 Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs
maxim,max6625 9-Bit/12-Bit Temperature Sensors with I²C-Compatible Serial Interface
--
1.9.1

2014-11-08 17:25:54

by Darshana Padmadas

[permalink] [raw]
Subject: [PATCH v5 2/4] dt-bindings: Document deprecated device vendor name to fix related warning

This patch documents deprecated vendor name "isil" to fix warning of
undocumented string for device isl29028 as reported while running checkpatch.pl
on drivers/staging/iio/light/isl29028.c. This is done to maintain compatibility
with older kernels.

Signed-off-by: Darshana Padmadas <[email protected]>
Acked-by: Arnd Bergmann <[email protected]>
Acked-by: Mark Rutland <[email protected]>
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index ac7269f..ab97459 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -68,6 +68,7 @@ img Imagination Technologies Ltd.
intel Intel Corporation
intercontrol Inter Control Group
isee ISEE 2007 S.L.
+isil Intersil (deprecated, use isl)
isl Intersil
karo Ka-Ro electronics GmbH
keymile Keymile GmbH
--
1.9.1

2014-11-08 17:26:26

by Darshana Padmadas

[permalink] [raw]
Subject: [PATCH v5 3/4] Staging: iio: light: Added correct vendor-prefix for device isl29028

This patch adds the correct vendor-prefix for device isl29028 and
maintains deprecated vendor-prefix found by checkpatch warning
for older kernel releases.

Signed-off-by: Darshana Padmadas <[email protected]>
Acked-by: Arnd Bergmann <[email protected]>
Acked-by: Mark Rutland <[email protected]>
Acked-by: Jonathan Cameron <[email protected]>
---
drivers/staging/iio/light/isl29028.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
index 6014625..e969107 100644
--- a/drivers/staging/iio/light/isl29028.c
+++ b/drivers/staging/iio/light/isl29028.c
@@ -537,7 +537,8 @@ static const struct i2c_device_id isl29028_id[] = {
MODULE_DEVICE_TABLE(i2c, isl29028_id);

static const struct of_device_id isl29028_of_match[] = {
- { .compatible = "isil,isl29028", },
+ { .compatible = "isl,isl29028", },
+ { .compatible = "isil,isl29028", },/* deprecated, don't use */
{ },
};
MODULE_DEVICE_TABLE(of, isl29028_of_match);
--
1.9.1

2014-11-08 17:27:12

by Darshana Padmadas

[permalink] [raw]
Subject: [PATCH v5 4/4] arch: arm: boot: dts: Correct vendor-prefix for iio device isl29028 in compatible property

This patch corrects the vendor-prefix for isl29028 in the compatible property from
"isil,isl29028" to "isl,isl29028" according to listed vendor-prefixes in
Documentation/devicetree/bindings/vendor-prefixes.txt. Incorrect vendor-prefix "isl"
was reported by checkpatch.pl warning for drivers/staging/iio/light/isl29028.c.
Thus incorrect vendor-prefix "isil" was corrected for every mention of device isl29028.

Signed-off-by: Darshana Padmadas <[email protected]>
Acked-by: Arnd Bergmann <[email protected]>
Acked-by: Mark Rutland <[email protected]>
---
arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
index 2063795..dcc6c75 100644
--- a/arch/arm/boot/dts/tegra30-cardhu.dtsi
+++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi
@@ -187,7 +187,7 @@

/* ALS and Proximity sensor */
isl29028@44 {
- compatible = "isil,isl29028";
+ compatible = "isl,isl29028";
reg = <0x44>;
interrupt-parent = <&gpio>;
interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;
--
1.9.1

2014-11-20 11:22:04

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH v5 0/4] Correct vendor-prefix and document device isl29028

On Saturday 08 November 2014, Darshana Padmadas wrote:
> Patchset documents correct and the deprecated vendor-prefix found by checkpatch
> warning and also documents information of device isl29028 for compatibility.
> Patchset also includes corrected vendor-prefix and device name in compatible
> property for files with checkpatch warning of undocumented string "isil,isl29028".
>

Since nobody else has picked these up, I've put them into the arm-soc
tree in the next/dt branch now.

Thanks and sorry for the delay,

Arnd