2014-11-09 12:46:13

by Anil Kumar

[permalink] [raw]
Subject: [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure

If probe fails then we need to call pm_runtime_disable() to balance
out the previous pm_runtime_enable() call.

Signed-off-by: Anil Kumar <[email protected]>
---
:100644 100644 0eed9b1... 99c747d... M sound/soc/davinci/davinci-mcasp.c
sound/soc/davinci/davinci-mcasp.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
index 0eed9b1..99c747d 100644
--- a/sound/soc/davinci/davinci-mcasp.c
+++ b/sound/soc/davinci/davinci-mcasp.c
@@ -1235,6 +1235,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
ret = pm_runtime_get_sync(&pdev->dev);
if (IS_ERR_VALUE(ret)) {
dev_err(&pdev->dev, "pm_runtime_get_sync() failed\n");
+ pm_runtime_disable(&pdev->dev);
return ret;
}

--
1.9.2


2014-11-10 12:54:11

by Peter Ujfalusi

[permalink] [raw]
Subject: Re: [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure

On 11/09/2014 02:45 PM, Anil Kumar wrote:
> If probe fails then we need to call pm_runtime_disable() to balance
> out the previous pm_runtime_enable() call.

Acked-by: Peter Ujfalusi <[email protected]>

>
> Signed-off-by: Anil Kumar <[email protected]>
> ---
> :100644 100644 0eed9b1... 99c747d... M sound/soc/davinci/davinci-mcasp.c
> sound/soc/davinci/davinci-mcasp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index 0eed9b1..99c747d 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -1235,6 +1235,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
> ret = pm_runtime_get_sync(&pdev->dev);
> if (IS_ERR_VALUE(ret)) {
> dev_err(&pdev->dev, "pm_runtime_get_sync() failed\n");
> + pm_runtime_disable(&pdev->dev);
> return ret;
> }
>
>


--
P?ter

2014-11-10 13:47:29

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure

On Sun, Nov 09, 2014 at 06:15:14PM +0530, Anil Kumar wrote:
> If probe fails then we need to call pm_runtime_disable() to balance
> out the previous pm_runtime_enable() call.

applied, thanks.

Attachments:
(No filename) (193.00 B)
 signature.asc (473.00 B)
Digital signature Download all attachments