2014-11-10 19:00:48

by Giedrius Statkevicius

[permalink] [raw]
Subject: [PATCH] platform: hp_accel: Add SERIO_I8042 as a dependency since it now includes i8042.h/serio.h

Make hp_accel dependent on SERIO_I8042 in the Kconfig because since commit
a4c724d0723b078e4ab4670e557cda1795036a7a ('platform: hp_accel: add a i8042
filter to remove HPQ6000 data from kb bus stream') hp_accel includes i8042.h
and serio.h.

Reported-by: Jim Davis <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 4dcfb71..7d146e68 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -202,6 +202,7 @@ config TC1100_WMI
config HP_ACCEL
tristate "HP laptop accelerometer"
depends on INPUT && ACPI
+ depends on SERIO_I8042
select SENSORS_LIS3LV02D
select NEW_LEDS
select LEDS_CLASS
--
2.1.3


2014-11-11 05:16:10

by Darren Hart

[permalink] [raw]
Subject: Re: [PATCH] platform: hp_accel: Add SERIO_I8042 as a dependency since it now includes i8042.h/serio.h

On Mon, Nov 10, 2014 at 08:59:42PM +0200, Giedrius Statkevicius wrote:
> Make hp_accel dependent on SERIO_I8042 in the Kconfig because since commit
> a4c724d0723b078e4ab4670e557cda1795036a7a ('platform: hp_accel: add a i8042
> filter to remove HPQ6000 data from kb bus stream') hp_accel includes i8042.h
> and serio.h.
>
> Reported-by: Jim Davis <[email protected]>
> Signed-off-by: Giedrius Statkevičius <[email protected]>
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 4dcfb71..7d146e68 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -202,6 +202,7 @@ config TC1100_WMI
> config HP_ACCEL
> tristate "HP laptop accelerometer"
> depends on INPUT && ACPI
> + depends on SERIO_I8042

Whitespace error, this should be a tab. I suggest making whitespace visible in
your editor to avoid this kind of thing.

I've corrected it and queued it.

Thanks,

--
Darren Hart
Intel Open Source Technology Center