2014-11-11 03:22:06

by Xie XiuQi

Subject: [PATCH] documentation: Update sysfs path for rcu_cpu_stall_timeout

Commit 6bfc09e2327d ("rcu: Provide RCU CPU stall warnings for tiny RCU")
moved the rcu_cpu_stall_timeout module parameter from rcutree.c to
rcupdate.c, but failed to update Documentation/RCU/stallwarn.txt. This
commit therefore repairs this omission.

commit 96224daa16d6 ("documentation: Update sysfs path for rcu_cpu_stall_suppress")
updated the path for rcu_cpu_stall_suppress, but failed to update for
rcu_cpu_stall_timeout.

Signed-off-by: Xie XiuQi <[email protected]>
---
Documentation/RCU/stallwarn.txt | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/RCU/stallwarn.txt b/Documentation/RCU/stallwarn.txt
index ef5a2fd..da6a801 100644
--- a/Documentation/RCU/stallwarn.txt
+++ b/Documentation/RCU/stallwarn.txt
@@ -15,7 +15,7 @@ CONFIG_RCU_CPU_STALL_TIMEOUT
21 seconds.

This configuration parameter may be changed at runtime via the
- /sys/module/rcutree/parameters/rcu_cpu_stall_timeout, however
+ /sys/module/rcupdate/parameters/rcu_cpu_stall_timeout, however
this parameter is checked only at the beginning of a cycle.
So if you are 10 seconds into a 40-second stall, setting this
sysfs parameter to (say) five will shorten the timeout for the
--
1.7.1

2014-11-11 04:11:54

by Paul E. McKenney

Subject: Re: [PATCH] documentation: Update sysfs path for rcu_cpu_stall_timeout

On Tue, Nov 11, 2014 at 12:03:26PM +0800, Xie XiuQi wrote:
> Commit 6bfc09e2327d ("rcu: Provide RCU CPU stall warnings for tiny RCU")
> moved the rcu_cpu_stall_timeout module parameter from rcutree.c to
> rcupdate.c, but failed to update Documentation/RCU/stallwarn.txt. This
> commit therefore repairs this omission.
>
> commit 96224daa16d6 ("documentation: Update sysfs path for rcu_cpu_stall_suppress")
> updated the path for rcu_cpu_stall_suppress, but failed to update for
> rcu_cpu_stall_timeout.
>
> Signed-off-by: Xie XiuQi <[email protected]>

Good catch, thank you! Queued for 3.20.

Thanx, Paul

> ---
> Documentation/RCU/stallwarn.txt | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/RCU/stallwarn.txt b/Documentation/RCU/stallwarn.txt
> index ef5a2fd..da6a801 100644
> --- a/Documentation/RCU/stallwarn.txt
> +++ b/Documentation/RCU/stallwarn.txt
> @@ -15,7 +15,7 @@ CONFIG_RCU_CPU_STALL_TIMEOUT
> 21 seconds.
>
> This configuration parameter may be changed at runtime via the
> - /sys/module/rcutree/parameters/rcu_cpu_stall_timeout, however
> + /sys/module/rcupdate/parameters/rcu_cpu_stall_timeout, however
> this parameter is checked only at the beginning of a cycle.
> So if you are 10 seconds into a 40-second stall, setting this
> sysfs parameter to (say) five will shorten the timeout for the
> --
> 1.7.1
>