2014-11-11 13:23:01

by Laurentiu Palcu

[permalink] [raw]

Subject: [PATCH] spi/rockchip: remove redundant call to spi_master_put()

---

The call to spi_master_put() in rockchip_spi_remove() is redundant since
the master is registered using devm_. This patch removes it.

Signed-off-by: Laurentiu Palcu <[email protected]>
---
drivers/spi/spi-rockchip.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index 3afc266..e8cfe6c 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -724,8 +724,6 @@ static int rockchip_spi_remove(struct platform_device *pdev)
if (rs->dma_rx.ch)
dma_release_channel(rs->dma_rx.ch);

- spi_master_put(master);
-
return 0;
}

--
1.9.1

2014-11-12 15:05:56

by Mark Brown

[permalink] [raw]

Subject: Re: [PATCH] spi/rockchip: remove redundant call to spi_master_put()

---

On Tue, Nov 11, 2014 at 03:22:51PM +0200, Laurentiu Palcu wrote:
> The call to spi_master_put() in rockchip_spi_remove() is redundant since
> the master is registered using devm_. This patch removes it.

Applied, thanks.

---

Attachments:

(No filename) (221.00 B)
signature.asc (473.00 B)
Digital signature Download all attachments