2014-11-14 18:38:50

by Fabian Frédérick

Subject: [PATCH 1/1 net-next] net: dsa: replace count*size kzalloc by kcalloc

kcalloc manages count*sizeof overflow.

Signed-off-by: Fabian Frederick <[email protected]>
---
net/dsa/dsa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
index 4648f12..e84b656 100644
--- a/net/dsa/dsa.c
+++ b/net/dsa/dsa.c
@@ -606,8 +606,8 @@ static int dsa_of_probe(struct platform_device *pdev)
if (pd->nr_chips > DSA_MAX_SWITCHES)
pd->nr_chips = DSA_MAX_SWITCHES;

- pd->chip = kzalloc(pd->nr_chips * sizeof(struct dsa_chip_data),
- GFP_KERNEL);
+ pd->chip = kcalloc(pd->nr_chips, sizeof(struct dsa_chip_data),
+ GFP_KERNEL);
if (!pd->chip) {
ret = -ENOMEM;
goto out_free;
--
1.9.3

2014-11-16 19:44:08

by David Miller

Subject: Re: [PATCH 1/1 net-next] net: dsa: replace count*size kzalloc by kcalloc

From: Fabian Frederick <[email protected]>
Date: Fri, 14 Nov 2014 19:38:23 +0100

> kcalloc manages count*sizeof overflow.
>
> Signed-off-by: Fabian Frederick <[email protected]>

Applied.