2014-11-16 12:33:56

by Fabian Frédérick

Subject: [PATCH 1/1 linux-next] iio: common: remove unnecessary sizeof(u8)

sizeof(u8) is always 1.

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/iio/common/st_sensors/st_sensors_spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/common/st_sensors/st_sensors_spi.c b/drivers/iio/common/st_sensors/st_sensors_spi.c
index 78a6a1a..5b37737 100644
--- a/drivers/iio/common/st_sensors/st_sensors_spi.c
+++ b/drivers/iio/common/st_sensors/st_sensors_spi.c
@@ -54,7 +54,7 @@ static int st_sensors_spi_read(struct st_sensor_transfer_buffer *tb,
if (err)
goto acc_spi_read_error;

- memcpy(data, tb->rx_buf, len*sizeof(u8));
+ memcpy(data, tb->rx_buf, len);
mutex_unlock(&tb->buf_lock);
return len;

--
1.9.3

2014-11-22 01:26:19

by Hartmut Knaack

Subject: Re: [PATCH 1/1 linux-next] iio: common: remove unnecessary sizeof(u8)

Fabian Frederick schrieb am 16.11.2014 13:33:
> sizeof(u8) is always 1.
>
> Signed-off-by: Fabian Frederick <[email protected]>
Acked-by: Hartmut Knaack <[email protected]>
> ---
> drivers/iio/common/st_sensors/st_sensors_spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/st_sensors/st_sensors_spi.c b/drivers/iio/common/st_sensors/st_sensors_spi.c
> index 78a6a1a..5b37737 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_spi.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_spi.c
> @@ -54,7 +54,7 @@ static int st_sensors_spi_read(struct st_sensor_transfer_buffer *tb,
> if (err)
> goto acc_spi_read_error;
>
> - memcpy(data, tb->rx_buf, len*sizeof(u8));
> + memcpy(data, tb->rx_buf, len);
> mutex_unlock(&tb->buf_lock);
> return len;
>
>

2014-11-22 12:07:13

by Jonathan Cameron

Subject: Re: [PATCH 1/1 linux-next] iio: common: remove unnecessary sizeof(u8)

On 22/11/14 01:26, Hartmut Knaack wrote:
> Fabian Frederick schrieb am 16.11.2014 13:33:
>> sizeof(u8) is always 1.
>>
>> Signed-off-by: Fabian Frederick <[email protected]>
> Acked-by: Hartmut Knaack <[email protected]>
Applied to the togreg branch of iio.git - initially pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan
>> ---
>> drivers/iio/common/st_sensors/st_sensors_spi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/common/st_sensors/st_sensors_spi.c b/drivers/iio/common/st_sensors/st_sensors_spi.c
>> index 78a6a1a..5b37737 100644
>> --- a/drivers/iio/common/st_sensors/st_sensors_spi.c
>> +++ b/drivers/iio/common/st_sensors/st_sensors_spi.c
>> @@ -54,7 +54,7 @@ static int st_sensors_spi_read(struct st_sensor_transfer_buffer *tb,
>> if (err)
>> goto acc_spi_read_error;
>>
>> - memcpy(data, tb->rx_buf, len*sizeof(u8));
>> + memcpy(data, tb->rx_buf, len);
>> mutex_unlock(&tb->buf_lock);
>> return len;
>>
>>
>