2014-11-17 21:08:27

by Fabian Frédérick

Subject: [PATCH 1/1 net-next] net/core: include linux/types.h instead of asm/types.h

Signed-off-by: Fabian Frederick <[email protected]>
---
net/core/link_watch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/link_watch.c b/net/core/link_watch.c
index bd0767e..49a9e3e 100644
--- a/net/core/link_watch.c
+++ b/net/core/link_watch.c
@@ -21,7 +21,7 @@
#include <linux/spinlock.h>
#include <linux/workqueue.h>
#include <linux/bitops.h>
-#include <asm/types.h>
+#include <linux/types.h>


enum lw_bits {
--
1.9.3

2014-11-17 21:22:59

by Eric Dumazet

Subject: Re: [PATCH 1/1 net-next] net/core: include linux/types.h instead of asm/types.h

On Mon, 2014-11-17 at 22:08 +0100, Fabian Frederick wrote:
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
> net/core/link_watch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/link_watch.c b/net/core/link_watch.c
> index bd0767e..49a9e3e 100644
> --- a/net/core/link_watch.c
> +++ b/net/core/link_watch.c
> @@ -21,7 +21,7 @@
> #include <linux/spinlock.h>
> #include <linux/workqueue.h>
> #include <linux/bitops.h>
> -#include <asm/types.h>
> +#include <linux/types.h>
>

We have 99 such occurrences in net/

Are you going to send 99 patches ?

2014-11-17 21:35:39

by David Miller

Subject: Re: [PATCH 1/1 net-next] net/core: include linux/types.h instead of asm/types.h

From: Eric Dumazet <[email protected]>
Date: Mon, 17 Nov 2014 13:22:56 -0800

> On Mon, 2014-11-17 at 22:08 +0100, Fabian Frederick wrote:
>> Signed-off-by: Fabian Frederick <[email protected]>
>> ---
>> net/core/link_watch.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/core/link_watch.c b/net/core/link_watch.c
>> index bd0767e..49a9e3e 100644
>> --- a/net/core/link_watch.c
>> +++ b/net/core/link_watch.c
>> @@ -21,7 +21,7 @@
>> #include <linux/spinlock.h>
>> #include <linux/workqueue.h>
>> #include <linux/bitops.h>
>> -#include <asm/types.h>
>> +#include <linux/types.h>
>>
>
> We have 99 such occurrences in net/
>
> Are you going to send 99 patches ?

Yeah, probably best to consolidate into one or a few patches.

2014-11-17 22:06:03

by Eric Dumazet

Subject: Re: [PATCH 1/1 net-next] net/core: include linux/types.h instead of asm/types.h

On Mon, 2014-11-17 at 16:35 -0500, David Miller wrote:
> From: Eric Dumazet <[email protected]>
> Date: Mon, 17 Nov 2014 13:22:56 -0800
>
> > On Mon, 2014-11-17 at 22:08 +0100, Fabian Frederick wrote:
> >> Signed-off-by: Fabian Frederick <[email protected]>
> >> ---
> >> net/core/link_watch.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/net/core/link_watch.c b/net/core/link_watch.c
> >> index bd0767e..49a9e3e 100644
> >> --- a/net/core/link_watch.c
> >> +++ b/net/core/link_watch.c
> >> @@ -21,7 +21,7 @@
> >> #include <linux/spinlock.h>
> >> #include <linux/workqueue.h>
> >> #include <linux/bitops.h>
> >> -#include <asm/types.h>
> >> +#include <linux/types.h>
> >>
> >
> > We have 99 such occurrences in net/
> >
> > Are you going to send 99 patches ?
>
> Yeah, probably best to consolidate into one or a few patches.

BTW the 99 occurrences are for asm/uaccess.h, it seems I gave the reply
on the wrong patch.

2014-11-18 20:55:50

by David Miller

Subject: Re: [PATCH 1/1 net-next] net/core: include linux/types.h instead of asm/types.h

From: Fabian Frederick <[email protected]>
Date: Mon, 17 Nov 2014 22:08:22 +0100

> Signed-off-by: Fabian Frederick <[email protected]>

Applied.