2014-11-26 20:16:10

by Jilai Wang

[permalink] [raw]
Subject: [PATCH 1/4] drm/msm/hdmi: use HPD interrupt to track connector status change

HPD interrupt can be tracked for each connector, so don't need
to poll the connector status for state change.

Change-Id: I2c062838af5922d32ce87a50676a45dcaedb44f2
Signed-off-by: Jilai Wang <[email protected]>
---
drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
index 4aca2a3..92fddd8 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
@@ -242,7 +242,7 @@ hotplug_work(struct work_struct *work)
struct hdmi_connector *hdmi_connector =
container_of(work, struct hdmi_connector, hpd_work);
struct drm_connector *connector = &hdmi_connector->base;
- drm_helper_hpd_irq_event(connector->dev);
+ drm_kms_helper_hotplug_event(connector->dev);
}

void hdmi_connector_irq(struct drm_connector *connector)
@@ -431,9 +431,6 @@ struct drm_connector *hdmi_connector_init(struct hdmi *hdmi)
DRM_MODE_CONNECTOR_HDMIA);
drm_connector_helper_add(connector, &hdmi_connector_helper_funcs);

- connector->polled = DRM_CONNECTOR_POLL_CONNECT |
- DRM_CONNECTOR_POLL_DISCONNECT;
-
connector->interlace_allowed = 1;
connector->doublescan_allowed = 0;

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


2014-11-26 23:43:05

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH 1/4] drm/msm/hdmi: use HPD interrupt to track connector status change

On Wed, Nov 26, 2014 at 12:15 PM, Jilai Wang <[email protected]> wrote:
> HPD interrupt can be tracked for each connector, so don't need
> to poll the connector status for state change.
>
> Change-Id: I2c062838af5922d32ce87a50676a45dcaedb44f2

Please remove the Change-Id when sending patches to the kernel.

Regards,
Bjorn