2014-11-29 12:56:02

by Anjana Sasindran

Subject: [PATCH] staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a line after declaration

This patch fix the checkpatch.pl warning

WARNING:Missing a blank line after declaration

Signed-off-by: Anjana Sasindran <[email protected]>
---
drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
index 7202d8e..5fa813d 100644
--- a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
+++ b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
@@ -234,6 +234,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
/* register div per output */
for (i = WZRD_NUM_OUTPUTS - 1; i >= 0 ; i--) {
const char *clkout_name;
+
if (of_property_read_string_index(np, "clock-output-names", i,
&clkout_name)) {
dev_err(&pdev->dev,
--
1.9.1

2014-11-30 18:12:56

by Soren Brinkmann

Subject: Re: [PATCH] staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a line after declaration

On Sat, 2014-11-29 at 06:25PM +0530, Anjana Sasindran wrote:
> This patch fix the checkpatch.pl warning
>
> WARNING:Missing a blank line after declaration

There are two such warnings. If we gonna fix them, please fix them all.

>
> Signed-off-by: Anjana Sasindran <[email protected]>
Acked-by: Soren Brinkmann <[email protected]>

Thanks,
Sören

2014-12-03 00:37:59

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a line after declaration

On Sat, Nov 29, 2014 at 06:25:30PM +0530, Anjana Sasindran wrote:
> This patch fix the checkpatch.pl warning
>
> WARNING:Missing a blank line after declaration
>
> Signed-off-by: Anjana Sasindran <[email protected]>
> ---
> drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> index 7202d8e..5fa813d 100644
> --- a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> +++ b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> @@ -234,6 +234,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
> /* register div per output */
> for (i = WZRD_NUM_OUTPUTS - 1; i >= 0 ; i--) {
> const char *clkout_name;
> +
> if (of_property_read_string_index(np, "clock-output-names", i,
> &clkout_name)) {
> dev_err(&pdev->dev,
> --
> 1.9.1

ALWAYS run your patches through checkpatch.pl so you don't get angry
emails from maintainers telling you that you added a warning with a
patch you were trying to get applied to remove a warning, making this a
pointless exercise :(

greg k-h