2014-11-29 16:21:04

by Athira Sharikkal

Subject: [PATCH] Drivers:input:mousedev.c: Fixed trailing statement on the next line

Fixed checkpatch error:
trailing statements should be on next line

signed-off-by: Athira S <[email protected]>
---
drivers/input/mousedev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c
index be2cc5c..28988f5 100644
--- a/drivers/input/mousedev.c
+++ b/drivers/input/mousedev.c
@@ -248,8 +248,8 @@ static void mousedev_key_event(struct mousedev *mousedev,
case BTN_4:
case BTN_EXTRA: index = 4; break;

- default:
- return;
+ default:
+ return;
}

if (value) {
--
1.9.1

2014-11-29 17:54:47

by Joe Perches

Subject: Re: [PATCH] Drivers:input:mousedev.c: Fixed trailing statement on the next line

On Sat, 2014-11-29 at 21:50 +0530, Athira S wrote:
> Fixed checkpatch error:
> trailing statements should be on next line
>
> signed-off-by: Athira S <[email protected]>
> ---
> drivers/input/mousedev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c
> index be2cc5c..28988f5 100644
> --- a/drivers/input/mousedev.c
> +++ b/drivers/input/mousedev.c
> @@ -248,8 +248,8 @@ static void mousedev_key_event(struct mousedev *mousedev,
> case BTN_4:
> case BTN_EXTRA: index = 4; break;
>
> - default:
> - return;
> + default:
> + return;

Please run your suggested patches though
scripts/checkpatch.pl before sending them.

Don't send patches on top of your own
unapplied patches. Use the original and
create a new patch.

Probably none of this needs to be changed.