2014-12-02 04:29:30

by Masahiro Yamada

[permalink] [raw]
Subject: [PATCH] kbuild: remove old information in headers_install.txt document

The arch header directories "include/asm-*" were moved long before.

Signed-off-by: Masahiro Yamada <[email protected]>
---

Documentation/kbuild/headers_install.txt | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/Documentation/kbuild/headers_install.txt b/Documentation/kbuild/headers_install.txt
index 951eb9f..0d8fe5e 100644
--- a/Documentation/kbuild/headers_install.txt
+++ b/Documentation/kbuild/headers_install.txt
@@ -28,10 +28,7 @@ optional arguments:

ARCH indicates which architecture to produce headers for, and defaults to the
current architecture. The linux/asm directory of the exported kernel headers
-is platform-specific, to see a complete list of supported architectures use
-the command:
-
- ls -d include/asm-* | sed 's/.*-//'
+is platform-specific.

INSTALL_HDR_PATH indicates where to install the headers. It defaults to
"./usr/include".
--
1.9.1


2014-12-02 13:39:31

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] kbuild: remove old information in headers_install.txt document

On Tue, 2 Dec 2014 13:28:53 +0900
Masahiro Yamada <[email protected]> wrote:

> diff --git a/Documentation/kbuild/headers_install.txt b/Documentation/kbuild/headers_install.txt
> index 951eb9f..0d8fe5e 100644
> --- a/Documentation/kbuild/headers_install.txt
> +++ b/Documentation/kbuild/headers_install.txt
> @@ -28,10 +28,7 @@ optional arguments:
>
> ARCH indicates which architecture to produce headers for, and defaults to the
> current architecture. The linux/asm directory of the exported kernel headers
> -is platform-specific, to see a complete list of supported architectures use
> -the command:
> -
> - ls -d include/asm-* | sed 's/.*-//'
> +is platform-specific.
>

This change makes sense as far as it goes, but might it not be better to
tell readers the way to get the list of supported architectures in the
new scheme of things...?

Thanks,

jon

2014-12-05 14:24:29

by Yann Droneaud

[permalink] [raw]
Subject: Re: [PATCH] kbuild: remove old information in headers_install.txt document

Hi,

Le mardi 02 décembre 2014 à 13:28 +0900, Masahiro Yamada a écrit :
> The arch header directories "include/asm-*" were moved long before.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> Documentation/kbuild/headers_install.txt | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/Documentation/kbuild/headers_install.txt b/Documentation/kbuild/headers_install.txt
> index 951eb9f..0d8fe5e 100644
> --- a/Documentation/kbuild/headers_install.txt
> +++ b/Documentation/kbuild/headers_install.txt
> @@ -28,10 +28,7 @@ optional arguments:
>
> ARCH indicates which architecture to produce headers for, and defaults to the
> current architecture. The linux/asm directory of the exported kernel headers
> -is platform-specific, to see a complete list of supported architectures use
> -the command:
> -
> - ls -d include/asm-* | sed 's/.*-//'
> +is platform-specific.
>
> INSTALL_HDR_PATH indicates where to install the headers. It defaults to
> "./usr/include".

Back in september, I've already sent a patch[1] to address this,
following a discussion with Sam Ravnborg[2]. See the mail thread[3].

Regards.

[1] http://lkml.kernel.org/r/b5181cf7604baa454c11f7aa92d07dd05349ce46.1410712841.git.ydroneaud@opteya.com
[2] http://lkml.kernel.org/r/[email protected]
[3] http://lkml.kernel.org/g/[email protected]

--
Yann Droneaud
OPTEYA


2014-12-11 01:43:09

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH] kbuild: remove old information in headers_install.txt document

Hi Yann,






On Fri, 05 Dec 2014 15:23:48 +0100
Yann Droneaud <[email protected]> wrote:

> Hi,
>
> Le mardi 02 decembre 2014 a 13:28 +0900, Masahiro Yamada a ecrit :
> > The arch header directories "include/asm-*" were moved long before.
> >
> > Signed-off-by: Masahiro Yamada <[email protected]>
> > ---
> >
> > Documentation/kbuild/headers_install.txt | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/Documentation/kbuild/headers_install.txt b/Documentation/kbuild/headers_install.txt
> > index 951eb9f..0d8fe5e 100644
> > --- a/Documentation/kbuild/headers_install.txt
> > +++ b/Documentation/kbuild/headers_install.txt
> > @@ -28,10 +28,7 @@ optional arguments:
> >
> > ARCH indicates which architecture to produce headers for, and defaults to the
> > current architecture. The linux/asm directory of the exported kernel headers
> > -is platform-specific, to see a complete list of supported architectures use
> > -the command:
> > -
> > - ls -d include/asm-* | sed 's/.*-//'
> > +is platform-specific.
> >
> > INSTALL_HDR_PATH indicates where to install the headers. It defaults to
> > "./usr/include".
>
> Back in september, I've already sent a patch[1] to address this,
> following a discussion with Sam Ravnborg[2]. See the mail thread[3].
>
> Regards.
>
> [1] http://lkml.kernel.org/r/b5181cf7604baa454c11f7aa92d07dd05349ce46.1410712841.git.ydroneaud@opteya.com
> [2] http://lkml.kernel.org/r/[email protected]
> [3] http://lkml.kernel.org/g/[email protected]
>

Sorry, I missed your patch.

You are the first, so I agree yours should go in.



Best Regards
Masahiro Yamada