2014-12-03 06:46:00

by Masahiro Yamada

[permalink] [raw]
Subject: [PATCH] kbuild: update headers_install.txt document

The arch header directories "include/asm-*" were moved long ago.
Now we should check the existence of arch/*/include/uapi/asm/Kbuild
to see if an architecture supports the headers installation.
(Actually, "um" is the only architecture that does not have it.)

Signed-off-by: Masahiro Yamada <[email protected]>
---

Documentation/kbuild/headers_install.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/kbuild/headers_install.txt b/Documentation/kbuild/headers_install.txt
index 951eb9f..8e668d4 100644
--- a/Documentation/kbuild/headers_install.txt
+++ b/Documentation/kbuild/headers_install.txt
@@ -31,7 +31,7 @@ current architecture. The linux/asm directory of the exported kernel headers
is platform-specific, to see a complete list of supported architectures use
the command:

- ls -d include/asm-* | sed 's/.*-//'
+ for i in arch/*; do [ -e $i/include/uapi/asm/Kbuild ] && basename $i; done

INSTALL_HDR_PATH indicates where to install the headers. It defaults to
"./usr/include".
--
1.9.1


2014-12-03 14:02:42

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] kbuild: update headers_install.txt document

On Wed, 3 Dec 2014 15:45:41 +0900
Masahiro Yamada <[email protected]> wrote:

> The arch header directories "include/asm-*" were moved long ago.
> Now we should check the existence of arch/*/include/uapi/asm/Kbuild
> to see if an architecture supports the headers installation.
> (Actually, "um" is the only architecture that does not have it.)
>
> Signed-off-by: Masahiro Yamada <[email protected]>

So please forgive me if I seem overly difficult and fussy, but... while
I'm all for fancy shell one-liners, wouldn't it be more straightforward,
in this case, to simply say in the documentation that all architectures
other than um have support?

Thanks,

jon