2014-12-03 22:35:08

by Jamie Lawler

Subject: [PATCH] Staging: octeon: Added blank lines after declarations

Hi,
There are 2 missing blank lines after declarations in
octeon/ethernet-rx.c. I have added them per the coding style.

Regards,
Jamie Lawler

Signed-off-by: Jamie Lawler <[email protected]>
---
drivers/staging/octeon/ethernet-rx.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c
index 1789a12..cecb806 100644
--- a/drivers/staging/octeon/ethernet-rx.c
+++ b/drivers/staging/octeon/ethernet-rx.c
@@ -109,6 +109,7 @@ static inline int cvm_oct_check_rcv_error(cvmx_wqe_t *work)
int interface = cvmx_helper_get_interface_num(work->ipprt);
int index = cvmx_helper_get_interface_index_num(work->ipprt);
union cvmx_gmxx_rxx_frm_ctl gmxx_rxx_frm_ctl;
+
gmxx_rxx_frm_ctl.u64 =
cvmx_read_csr(CVMX_GMXX_RXX_FRM_CTL(index, interface));
if (gmxx_rxx_frm_ctl.s.pre_chk == 0) {
@@ -212,6 +213,7 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, int budget)
did_work_request = 0;
if (work == NULL) {
union cvmx_pow_wq_int wq_int;
+
wq_int.u64 = 0;
wq_int.s.iq_dis = 1 << pow_receive_group;
wq_int.s.wq_int = 1 << pow_receive_group;
--
2.1.0

2014-12-04 08:41:12

by Dan Carpenter

Subject: Re: [PATCH] Staging: octeon: Added blank lines after declarations

On Wed, Dec 03, 2014 at 10:35:03PM +0000, Jamie Lawler wrote:
> Hi,
> There are 2 missing blank lines after declarations in
> octeon/ethernet-rx.c. I have added them per the coding style.
>
> Regards,
> Jamie Lawler
>

This is the changelog entry. Don't put email stuff here like the "Hi"
and "Regards, Jamie Lawler" otherwise it makes the git log look weird.

regards,
dan carpenter