2014-12-04 10:17:21

by Seung-Woo Kim

[permalink] [raw]
Subject: [PATCH] regulator: core: Fix regualtor_ena_gpio_free not to access pin after freeing

After freeing pin from regulator_ena_gpio_free, loop can access
the pin. So this patch fixes not to access pin after freeing.

Signed-off-by: Seung-Woo Kim <[email protected]>
---
drivers/regulator/core.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index cd87c0c..479ef0b 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1713,6 +1713,8 @@ static void regulator_ena_gpio_free(struct regulator_dev *rdev)
gpiod_put(pin->gpiod);
list_del(&pin->list);
kfree(pin);
+ rdev->ena_pin = NULL;
+ return;
} else {
pin->request_count--;
}
--
1.7.4.1


2014-12-04 22:45:59

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: core: Fix regualtor_ena_gpio_free not to access pin after freeing

On Thu, Dec 04, 2014 at 07:17:17PM +0900, Seung-Woo Kim wrote:
> After freeing pin from regulator_ena_gpio_free, loop can access
> the pin. So this patch fixes not to access pin after freeing.

Applied, thanks.


Attachments:
(No filename) (211.00 B)
signature.asc (473.00 B)
Digital signature
Download all attachments