2014-12-05 11:20:06

by Sanjay Singh Rawat

Subject: [PATCH] usb: gadget: f_mass_storage: restore address range on exit

At the start of the thread we are changing the address limit, restoring it
to the default while exiting.

Signed-off-by: Sanjay Singh Rawat <[email protected]>
---
drivers/usb/gadget/function/f_mass_storage.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c
index 811929c..c4a2ded 100644
--- a/drivers/usb/gadget/function/f_mass_storage.c
+++ b/drivers/usb/gadget/function/f_mass_storage.c
@@ -2489,6 +2489,7 @@ static void handle_exception(struct fsg_common *common)
static int fsg_main_thread(void *common_)
{
struct fsg_common *common = common_;
+ mm_segment_t fs = get_fs();

/*
* Allow the thread to be killed by a signal, but set the signal mask
@@ -2567,6 +2568,7 @@ static int fsg_main_thread(void *common_)
up_write(&common->filesem);
}

+ set_fs(fs);
/* Let fsg_unbind() know the thread has exited */
complete_and_exit(&common->thread_notifier, 0);
}
--
1.8.3.2

2014-12-05 20:12:56

by Alan Stern

Subject: Re: [PATCH] usb: gadget: f_mass_storage: restore address range on exit

On Fri, 5 Dec 2014, Sanjay Singh Rawat wrote:

> At the start of the thread we are changing the address limit, restoring it
> to the default while exiting.

What for? The thread is about to exit anyway. Who cares what the
address limit is set to?

Alan Stern