2014-12-09 01:11:11

by weiyj_lk

[permalink] [raw]
Subject: [PATCH -next] ASoC: Intel: fix sparse non static symbol warnings

From: Wei Yongjun <[email protected]>

Fixes the following sparse warnings:

sound/soc/intel/sst/sst_acpi.c:248:5: warning:
symbol 'sst_acpi_probe' was not declared. Should it be static?
sound/soc/intel/sst/sst_acpi.c:335:5: warning:
symbol 'sst_acpi_remove' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <[email protected]>
---
sound/soc/intel/sst/sst_acpi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/intel/sst/sst_acpi.c b/sound/soc/intel/sst/sst_acpi.c
index 31124aa..98a8f66 100644
--- a/sound/soc/intel/sst/sst_acpi.c
+++ b/sound/soc/intel/sst/sst_acpi.c
@@ -245,7 +245,7 @@ static struct sst_machines *sst_acpi_find_machine(
return NULL;
}

-int sst_acpi_probe(struct platform_device *pdev)
+static int sst_acpi_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
int ret = 0;
@@ -332,7 +332,7 @@ do_sst_cleanup:
* This function is called by OS when a device is unloaded
* This frees the interrupt etc
*/
-int sst_acpi_remove(struct platform_device *pdev)
+static int sst_acpi_remove(struct platform_device *pdev)
{
struct intel_sst_drv *ctx;


2014-12-22 17:59:21

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH -next] ASoC: Intel: fix sparse non static symbol warnings

On Tue, Dec 09, 2014 at 09:10:44AM +0800, [email protected] wrote:
> From: Wei Yongjun <[email protected]>
>
> Fixes the following sparse warnings:

Applied, thanks.


Attachments:
(No filename) (178.00 B)
signature.asc (473.00 B)
Digital signature
Download all attachments