2014-12-09 02:53:05

by Yunzhi Li

Subject: [PATCH v4 4/5] ARM: dts: add rk3288 usb PHY

This patch adds a device_node for RK3288 SoC usb phy. It also
defines the phy to be used by three usb controllers: usb_host0/1
and usb_otg.

Signed-off-by: Yunzhi Li <[email protected]>

---

Changes in v4:
- Add phy subnodes.

Changes in v3: None

arch/arm/boot/dts/rk3288.dtsi | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 874e66d..2db2d12 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -329,12 +329,35 @@
status = "disabled";
};

+ usbphy: phy {
+ #phy-cells = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "rockchip,rk3288-usb-phy";
+ rockchip,grf = <&grf>;
+ status = "disabled";
+
+ usb-phy@0 {
+ reg = <0>;
+ };
+
+ usb-phy@1 {
+ reg = <1>;
+ };
+
+ usb-phy@2 {
+ reg = <2>;
+ };
+ };
+
usb_host0_ehci: usb@ff500000 {
compatible = "generic-ehci";
reg = <0xff500000 0x100>;
interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru HCLK_USBHOST0>;
clock-names = "usbhost";
+ phys = <&usbphy 1>;
+ phy-names = "usb";
status = "disabled";
};

@@ -347,6 +370,8 @@
interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru HCLK_USBHOST1>;
clock-names = "otg";
+ phys = <&usbphy 2>;
+ phy-names = "usb2-phy";
status = "disabled";
};

@@ -357,6 +382,8 @@
interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru HCLK_OTG0>;
clock-names = "otg";
+ phys = <&usbphy 0>;
+ phy-names = "usb2-phy";
status = "disabled";
};

--
2.0.0

2014-12-09 10:27:43

by Heiko Stuebner

Subject: Re: [PATCH v4 4/5] ARM: dts: add rk3288 usb PHY

Hi,

Am Dienstag, 9. Dezember 2014, 10:52:34 schrieb Yunzhi Li:
> This patch adds a device_node for RK3288 SoC usb phy. It also
> defines the phy to be used by three usb controllers: usb_host0/1
> and usb_otg.
>
> Signed-off-by: Yunzhi Li <[email protected]>
>
> ---
>
> Changes in v4:
> - Add phy subnodes.
>
> Changes in v3: None
>
> arch/arm/boot/dts/rk3288.dtsi | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 874e66d..2db2d12 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -329,12 +329,35 @@
> status = "disabled";
> };
>
> + usbphy: phy {

the nodes in the dts are ordered by address, please move it accordingly. I
guess a good position might be to have the "phy" before the "pinctrl" node.

Also please reorder the properties a bit to have the "compatible" at the top
of the list, like

compatible = "rockchip,rk3288-usb-phy";
rockchip,grf = <&grf>;
#phy-cells = <1>;
#address-cells = <1>;
#size-cells = <0>;
status = "disabled";

subnodes...


Thanks
Heiko

> + #phy-cells = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "rockchip,rk3288-usb-phy";
> + rockchip,grf = <&grf>;
> + status = "disabled";
> +
> + usb-phy@0 {
> + reg = <0>;
> + };
> +
> + usb-phy@1 {
> + reg = <1>;
> + };
> +
> + usb-phy@2 {
> + reg = <2>;
> + };
> + };
> +
> usb_host0_ehci: usb@ff500000 {
> compatible = "generic-ehci";
> reg = <0xff500000 0x100>;
> interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cru HCLK_USBHOST0>;
> clock-names = "usbhost";
> + phys = <&usbphy 1>;
> + phy-names = "usb";
> status = "disabled";
> };
>
> @@ -347,6 +370,8 @@
> interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cru HCLK_USBHOST1>;
> clock-names = "otg";
> + phys = <&usbphy 2>;
> + phy-names = "usb2-phy";
> status = "disabled";
> };
>
> @@ -357,6 +382,8 @@
> interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cru HCLK_OTG0>;
> clock-names = "otg";
> + phys = <&usbphy 0>;
> + phy-names = "usb2-phy";
> status = "disabled";
> };

2014-12-09 14:13:38

by Romain Perier

Subject: Re: [PATCH v4 4/5] ARM: dts: add rk3288 usb PHY

Hi,

2014-12-09 3:52 GMT+01:00 Yunzhi Li <[email protected]>:
> This patch adds a device_node for RK3288 SoC usb phy. It also
> defines the phy to be used by three usb controllers: usb_host0/1
> and usb_otg.
>
> Signed-off-by: Yunzhi Li <[email protected]>
>
> ---
>

Tiny thing: Could you change your short description to "ARM: dts:
rockchip: add rk3288 usb PHY" ? (as this is the case for all
devicetree related changes for a specific SoC)

Thanks,
Romain